Bug 1212285
| Summary: | [lshw] beaker-system-scan does not determine system vendor and model correctly | ||
|---|---|---|---|
| Product: | [Retired] Beaker | Reporter: | Dan Callaghan <dcallagh> |
| Component: | inventory | Assignee: | beaker-dev-list |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 20 | CC: | aigao, dcallagh, dowang, ebaak |
| Target Milestone: | 21.0 | Keywords: | Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-08-26 06:18:00 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 541294 | ||
|
Description
Dan Callaghan
2015-04-16 06:00:16 UTC
(In reply to Dan Callaghan from comment #0) > Current beaker-system-scan determines vendor and model from some unknown > place? lshw does not appear to do this. Need to figure out where these > strings come from in smolt and whether lshw can produce the same. smolt gets it from '/org/freedesktop/Hal/devices/computer'. Let's see where else that is available from. (In reply to Amit Saha from comment #1) Might be worth figuring out where HAL itself was getting that info from. In many cases udev will now have the same info. (In reply to Dan Callaghan from comment #2) > (In reply to Amit Saha from comment #1) > > Might be worth figuring out where HAL itself was getting that info from. In > many cases udev will now have the same info. HAL gets it from SMBIOS which is also used by lshw. The XML parsing was not correct in beaker-system-scan: http://gerrit.beaker-project.org/#/c/4188/ I will need to verify it on the other systems. I think we will need to patch lshw to extract the vendor correctly on POWER. This is clearly not right: 'model': 'IBM,8286-42A', 'vendor': None Also 'JS20' would be a more useful model string than '8842-P3A' (similarly 'P750E' would be more useful than '8233-E8B') but I guess we can live with it. (In reply to Dan Callaghan from comment #12) > I think we will need to patch lshw to extract the vendor correctly on POWER. > This is clearly not right: > > 'model': 'IBM,8286-42A', > 'vendor': None lshw gets the model value from: # cat /proc/device-tree/model IBM,8286-42A 8286-42A seems to be the model here: http://www-01.ibm.com/common/ssi/cgi-bin/ssialias?infotype=an&subtype=ca&appname=gpateam&supplier=897&letternum=ENUS114-059 What do you think of just splitting on the , and set vendor to IBM and model to 8286-42A ? (In reply to Amit Saha from comment #16) > What do you think of just splitting on the , and set vendor to IBM and model > to 8286-42A ? The IEEE 1275 spec doesn't prescribe any particular meaning for the "model" property beyond: Standard property name to define a manufacturer's model number. However it seems to be a convention in the spec to use "vendor,model" separated by a comma and I guess that is followed in the model property as well. So I think we could update lshw to split on , if present. (In reply to Dan Callaghan from comment #12) > I think we will need to patch lshw to extract the vendor correctly on POWER. > This is clearly not right: > > 'model': 'IBM,8286-42A', > 'vendor': None > > Also 'JS20' would be a more useful model string than '8842-P3A' (similarly > 'P750E' would be more useful than '8233-E8B') but I guess we can live with > it. http://gerrit.beaker-project.org/#/c/4193/1 Verify passed on beaker-system-scan-1.6-1.git.19.1c8487e.el6 Beaker 21.0 has been released. |