Bug 1212285 - [lshw] beaker-system-scan does not determine system vendor and model correctly
Summary: [lshw] beaker-system-scan does not determine system vendor and model correctly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: inventory
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 21.0
Assignee: beaker-dev-list
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks: 541294
TreeView+ depends on / blocked
 
Reported: 2015-04-16 06:00 UTC by Dan Callaghan
Modified: 2018-02-06 00:41 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-08-26 06:18:00 UTC
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2015-04-16 06:00:16 UTC
Current beaker-system-scan determines vendor and model from some unknown place? lshw does not appear to do this. Need to figure out where these strings come from in smolt and whether lshw can produce the same.

For example on a KVM guest:

Vendor: Red Hat
Model: KVM RHEL 6.0.0 PC

Comment 1 Amit Saha 2015-04-23 05:56:01 UTC
(In reply to Dan Callaghan from comment #0)
> Current beaker-system-scan determines vendor and model from some unknown
> place? lshw does not appear to do this. Need to figure out where these
> strings come from in smolt and whether lshw can produce the same.

smolt gets it from  '/org/freedesktop/Hal/devices/computer'.

Let's see where else that is available from.

Comment 2 Dan Callaghan 2015-04-23 06:01:56 UTC
(In reply to Amit Saha from comment #1)

Might be worth figuring out where HAL itself was getting that info from. In many cases udev will now have the same info.

Comment 3 Amit Saha 2015-04-23 06:37:53 UTC
(In reply to Dan Callaghan from comment #2)
> (In reply to Amit Saha from comment #1)
> 
> Might be worth figuring out where HAL itself was getting that info from. In
> many cases udev will now have the same info.

HAL gets it from SMBIOS which is also used by lshw. The XML parsing was not correct in beaker-system-scan:

http://gerrit.beaker-project.org/#/c/4188/

I will need to verify it on the other systems.

Comment 12 Dan Callaghan 2015-04-24 03:46:38 UTC
I think we will need to patch lshw to extract the vendor correctly on POWER. This is clearly not right:

 'model': 'IBM,8286-42A',
 'vendor': None

Also 'JS20' would be a more useful model string than '8842-P3A' (similarly 'P750E' would be more useful than '8233-E8B') but I guess we can live with it.

Comment 16 Amit Saha 2015-04-30 03:27:48 UTC
(In reply to Dan Callaghan from comment #12)
> I think we will need to patch lshw to extract the vendor correctly on POWER.
> This is clearly not right:
> 
>  'model': 'IBM,8286-42A',
>  'vendor': None

lshw gets the model value from:
# cat /proc/device-tree/model 
IBM,8286-42A

8286-42A seems to be the model here: http://www-01.ibm.com/common/ssi/cgi-bin/ssialias?infotype=an&subtype=ca&appname=gpateam&supplier=897&letternum=ENUS114-059

What do you think of just splitting on the , and set vendor to IBM and model to 8286-42A ?

Comment 17 Dan Callaghan 2015-04-30 03:52:36 UTC
(In reply to Amit Saha from comment #16)
> What do you think of just splitting on the , and set vendor to IBM and model
> to 8286-42A ?

The IEEE 1275 spec doesn't prescribe any particular meaning for the "model" property beyond:

Standard property name to define a manufacturer's model number.

However it seems to be a convention in the spec to use "vendor,model" separated by a comma and I guess that is followed in the model property as well. So I think we could update lshw to split on , if present.

Comment 19 Amit Saha 2015-04-30 06:20:07 UTC
(In reply to Dan Callaghan from comment #12)
> I think we will need to patch lshw to extract the vendor correctly on POWER.
> This is clearly not right:
> 
>  'model': 'IBM,8286-42A',
>  'vendor': None
> 
> Also 'JS20' would be a more useful model string than '8842-P3A' (similarly
> 'P750E' would be more useful than '8233-E8B') but I guess we can live with
> it.

http://gerrit.beaker-project.org/#/c/4193/1

Comment 25 wangdong 2015-05-18 08:33:31 UTC
Verify passed on beaker-system-scan-1.6-1.git.19.1c8487e.el6

Comment 27 Dan Callaghan 2015-08-26 06:18:00 UTC
Beaker 21.0 has been released.


Note You need to log in before you can comment on or make changes to this bug.