Bug 1212339

Summary: libvirt emitted a invalid option "-bootloader" to qemu-kvm
Product: Red Hat Enterprise Linux 6 Reporter: Song Wang <sowang>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED WONTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.7CC: dyuan, honzhang, jdenemar, jiahu, jtomko, mzhan, rbalakri, virt-bugs, vivianzhang
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1176050 Environment:
Last Closed: 2015-04-16 09:05:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1176050    
Bug Blocks:    

Description Song Wang 2015-04-16 08:23:20 UTC
+++ This bug was initially created as a clone of Bug #1176050 +++

Description of problem:
libvirt emitted a invalid option "-bootloader" to qemu-kvm

Version-Release number of selected component (if applicable):
libvirt-1.2.8-11.el7.x86_64
qemu-kvm-rhev-2.1.2-17.el7.x86_64

How reproducible:
100%

Steps to Reproduce:

[root@ibm-x3850x5-06 ~]# virsh dumpxml r7| grep bootloader -a4
  <vcpu placement='static'>2</vcpu>
  <resource>
    <partition>/machine</partition>
  </resource>
  <bootloader>/usr/bin/pygrub</bootloader>
  <bootloader_args>--append single</bootloader_args>
...

[root@ibm-x3850x5-06 ~]# virsh list --all
 Id    Name                           State
----------------------------------------------------
 -     r7                             shut off

[root@ibm-x3850x5-06 ~]# virsh start r7
error: Failed to start domain r7
error: internal error: process exited while connecting to monitor: qemu-kvm: -bootloader: invalid option


Actual results:
As shown above steps.

Expected results:
qemu-kvm does not support this option, so libvirt should not emit such option to qemu CLI.

Additional info:
[root@ibm-x3850x5-06 libvirt-1.2.8]# /usr/libexec/qemu-kvm -h | grep bootloader
[root@ibm-x3850x5-06 libvirt-1.2.8]#
[root@ibm-x3850x5-06 libvirt-1.2.8]#  < nothing output



--- Additional comment from Ján Tomko on 2015-03-02 01:51:48 EST ---

Pushed upstream:
commit 9aa316612aa74abf88b3eb97e1a0eda920dab94a
Author:     Ján Tomko <jtomko>
CommitDate: 2015-03-02 07:39:09 +0100

    Remove bootloader option from QEMU
    
    It was only supported by xenner (since commit 763a59d8),
    for which we removed support in commit de9be0a.
    
    Remove the code generating this command line option,
    refuse to parse it and delete the outdated tests.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1176050

git describe: v1.2.13-2-g9aa3166

Comment 2 Jiri Denemark 2015-04-16 09:05:39 UTC
I don't think there's any compelling reason to backport this change to RHEL 6. A domain with <bootleader> elemnet will fail to start anyway. It's just about changing the error message a little bit.