Bug 1212437

Summary: probing and detaching a peer generated a CRITICAL error - "Could not find peer" in glusterd logs
Product: [Community] GlusterFS Reporter: SATHEESARAN <sasundar>
Component: glusterdAssignee: Atin Mukherjee <amukherj>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: amukherj, bugs, gluster-bugs
Target Milestone: ---Keywords: Reopened, Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: GlusterD
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1252680 (view as bug list) Environment:
Last Closed: 2016-06-16 12:52:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1246946, 1252680    

Description SATHEESARAN 2015-04-16 12:11:27 UTC
Description of problem:
-----------------------
When probing a peer and detaching the same, I observed messages in glusterd log file with CRITICAL log level

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
glusterfs-3.7 nightly build (glusterfs-3.7dev-0.994.gitf522001.el6.x86_64)

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Probe a peer
2. Detach the same peer

Actual results:
---------------
I could see error messages with log-level set to CRITICAL in glusterd logs

Expected results:
-----------------
There shouldn't be any critical errors

Comment 1 Anand Avati 2015-04-16 12:29:58 UTC
REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2015-04-27 06:21:13 UTC
REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 3 Anand Avati 2015-04-28 01:03:08 UTC
REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#4) for review on master by Atin Mukherjee (amukherj)

Comment 4 Anand Avati 2015-04-29 08:20:06 UTC
REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#5) for review on master by Atin Mukherjee (amukherj)

Comment 5 Anand Avati 2015-07-13 05:01:05 UTC
REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#6) for review on master by Atin Mukherjee (amukherj)

Comment 6 Anand Avati 2015-08-12 05:05:59 UTC
COMMIT: http://review.gluster.org/10272 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 0dcdc8d9d797ed43d305fb3e3437c2576305ac46
Author: Atin Mukherjee <amukherj>
Date:   Thu Apr 16 17:54:24 2015 +0530

    glusterd: log improvement in glusterd_peer_rpc_notify
    
    If ping time out is enabled glusterd can receive a disconnect event from a peer
    which has been already deleted resulting into a critical log printed. This patch
    ensures that critical message is logged only when its a connect event.
    
    Change-Id: I67d9aa3f60195e08af7dfc8a42683422aaf90a00
    BUG: 1212437
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/10272
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Gaurav Kumar Garg <ggarg>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Krishnan Parthasarathi <kparthas>

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 15:20:44 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 8 Niels de Vos 2016-06-16 12:52:58 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user