+++ This bug was initially created as a clone of Bug #1212437 +++ Description of problem: ----------------------- When probing a peer and detaching the same, I observed messages in glusterd log file with CRITICAL log level Version-Release number of selected component (if applicable): ------------------------------------------------------------- glusterfs-3.7 nightly build (glusterfs-3.7dev-0.994.gitf522001.el6.x86_64) How reproducible: ----------------- Always Steps to Reproduce: ------------------- 1. Probe a peer 2. Detach the same peer Actual results: --------------- I could see error messages with log-level set to CRITICAL in glusterd logs Expected results: ----------------- There shouldn't be any critical errors --- Additional comment from Anand Avati on 2015-04-16 08:29:58 EDT --- REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#1) for review on master by Atin Mukherjee (amukherj) --- Additional comment from Anand Avati on 2015-04-27 02:21:13 EDT --- REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#3) for review on master by Atin Mukherjee (amukherj) --- Additional comment from Anand Avati on 2015-04-27 21:03:08 EDT --- REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#4) for review on master by Atin Mukherjee (amukherj) --- Additional comment from Anand Avati on 2015-04-29 04:20:06 EDT --- REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#5) for review on master by Atin Mukherjee (amukherj) --- Additional comment from Anand Avati on 2015-07-13 01:01:05 EDT --- REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in glusterd_peer_rpc_notify) posted (#6) for review on master by Atin Mukherjee (amukherj) --- Additional comment from Anand Avati on 2015-08-12 01:05:59 EDT --- COMMIT: http://review.gluster.org/10272 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 0dcdc8d9d797ed43d305fb3e3437c2576305ac46 Author: Atin Mukherjee <amukherj> Date: Thu Apr 16 17:54:24 2015 +0530 glusterd: log improvement in glusterd_peer_rpc_notify If ping time out is enabled glusterd can receive a disconnect event from a peer which has been already deleted resulting into a critical log printed. This patch ensures that critical message is logged only when its a connect event. Change-Id: I67d9aa3f60195e08af7dfc8a42683422aaf90a00 BUG: 1212437 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/10272 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Gaurav Kumar Garg <ggarg> Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: Krishnan Parthasarathi <kparthas>
Patch http://review.gluster.org/#/c/11886 posted for review
COMMIT: http://review.gluster.org/11886 committed in release-3.7 by Atin Mukherjee (amukherj) ------ commit a40f9b42390d1143c2bf6dc710414c11ceb6cc22 Author: Atin Mukherjee <amukherj> Date: Thu Apr 16 17:54:24 2015 +0530 glusterd: log improvement in glusterd_peer_rpc_notify Backport of http://review.gluster.org/#/c/10272/ If ping time out is enabled glusterd can receive a disconnect event from a peer which has been already deleted resulting into a critical log printed. This patch ensures that critical message is logged only when its a connect event. Change-Id: I67d9aa3f60195e08af7dfc8a42683422aaf90a00 BUG: 1252680 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/10272 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Gaurav Kumar Garg <ggarg> Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-on: http://review.gluster.org/11886 Reviewed-by: Anand Nekkunti <anekkunt>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report. glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user