Bug 1212699
Summary: | Review Request: mediawiki123-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrick Uiterwijk <puiterwijk> |
Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | kevin, package-review |
Target Milestone: | --- | Flags: | kevin:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | mediawiki123-HTTP302Found-2.0.1-3.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-05-29 21:45:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Patrick Uiterwijk
2015-04-17 06:57:57 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9495628 Note: I'm only interrested in EPEL7, as the main package (mediawiki123) is also only for EPEL7. For Fedora, we have the main mediawiki package. I'll review this. Look for a full review in a bit... OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: b6b5d50ae5b5b39a5590090e5f6e0bcb ../HTTP302Found-2.0.1.tar.gz OK - BuildRequires correct OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. 2 packages and 0 specfiles checked; 0 errors, 0 warnings. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin I see no issues with this package, so it's APPROVED. mediawiki123-HTTP302Found-2.0.1-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mediawiki123-HTTP302Found-2.0.1-3.el7 mediawiki123-HTTP302Found-2.0.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository. mediawiki123-HTTP302Found-2.0.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. |