Bug 1212699 - Review Request: mediawiki123-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects
Summary: Review Request: mediawiki123-HTTP302Found - Forces an external HTTP 302 redir...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-17 06:57 UTC by Patrick Uiterwijk
Modified: 2015-05-29 21:45 UTC (History)
2 users (show)

Fixed In Version: mediawiki123-HTTP302Found-2.0.1-3.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-29 21:45:26 UTC
Type: ---
Embargoed:
kevin: fedora-review+


Attachments (Terms of Use)

Description Patrick Uiterwijk 2015-04-17 06:57:57 UTC
Spec URL: http://puiterwijk.fedorapeople.org//mediawiki123-HTTP302Found.spec
SRPM URL: http://puiterwijk.fedorapeople.org//mediawiki123-HTTP302Found-2.0.1-3.fc21.src.rpm

Description:
Pushes a HTTP code 302 (Found) to the browser when there is a redirect instead
of handling it internally. The end user will not notice any difference (other
than the address to the page having an ?rd=Redirecting_page bit at the end).

Comment 1 Patrick Uiterwijk 2015-04-17 06:58:50 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9495628

Note: I'm only interrested in EPEL7, as the main package (mediawiki123) is also only for EPEL7.
For Fedora, we have the main mediawiki package.

Comment 2 Kevin Fenzi 2015-04-20 17:57:56 UTC
I'll review this. Look for a full review in a bit...

Comment 3 Kevin Fenzi 2015-04-20 19:02:41 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
b6b5d50ae5b5b39a5590090e5f6e0bcb  ../HTTP302Found-2.0.1.tar.gz

OK - BuildRequires correct
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
OK - No rpmlint output. 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin

I see no issues with this package, so it's APPROVED.

Comment 4 Fedora Update System 2015-04-20 20:29:39 UTC
mediawiki123-HTTP302Found-2.0.1-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mediawiki123-HTTP302Found-2.0.1-3.el7

Comment 5 Fedora Update System 2015-04-22 05:08:09 UTC
mediawiki123-HTTP302Found-2.0.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 6 Fedora Update System 2015-05-29 21:45:26 UTC
mediawiki123-HTTP302Found-2.0.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.