Bug 1213184 (grantlee-qt5)

Summary: Review Request: grantlee-qt5 - Qt string template engine based on the Django template system
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: Package ReviewAssignee: Jan Grulich <jgrulich>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jgrulich, kevin, package-review
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: jgrulich: fedora-review+
gwync: fedora-cvs+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 5.0.0-2.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-04 19:46:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 656997, 1239881    

Description Rex Dieter 2015-04-19 21:42:39 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5-5.0.0-1.fc22.src.rpm
Description: Qt string template engine based on the Django template system
Fedora Account System Username: rdieter

Newer parallel-installable grantlee-qt5 (vs existing qt4-based grantlee package)

Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=9515721

Comment 1 Rex Dieter 2015-05-28 19:12:24 UTC
*** Bug 1226026 has been marked as a duplicate of this bug. ***

Comment 2 Rex Dieter 2015-08-08 21:15:13 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5-5.0.0-2.fc22.src.rpm

%changelog
* Sat Aug 08 2015 Rex Dieter <rdieter>  5.0.0-2
- update URL

Comment 3 Jan Grulich 2015-08-26 20:22:56 UTC
1) Typo in BuildRequires: qt5-tools-devel, should be qt5-qttools-devel
2) Use %license macro instead of %doc for the license file
3) Some python files are also under BSD license so maybe the license should be LGPLv2+ and BSD

Otherwise looks good, all mentioned issues are not blockers and can be simply fixed during import. Approved.

Comment 4 Rex Dieter 2015-08-28 15:04:36 UTC
New Package SCM Request
=======================
Package Name: grantlee-qt5
Short Description: Qt string template engine based on the Django template system
Upstream URL: https://github.com/steveire/grantlee
Owners: rdieter group::kde-sig 
Branches: f22 f23
InitialCC:

Comment 5 Gwyn Ciesla 2015-08-30 14:20:55 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2015-08-30 23:19:35 UTC
imported

Comment 7 Fedora Update System 2015-08-31 11:52:33 UTC
grantlee-qt5-5.0.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14650

Comment 8 Fedora Update System 2015-09-01 10:04:40 UTC
grantlee-qt5-5.0.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update grantlee-qt5'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14650

Comment 9 Fedora Update System 2015-09-04 19:46:25 UTC
grantlee-qt5-5.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.