Bug 1213184 (grantlee-qt5) - Review Request: grantlee-qt5 - Qt string template engine based on the Django template system
Summary: Review Request: grantlee-qt5 - Qt string template engine based on the Django ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: grantlee-qt5
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: grantlee5 (view as bug list)
Depends On:
Blocks: kde-reviews 1239881
TreeView+ depends on / blocked
 
Reported: 2015-04-19 21:42 UTC by Rex Dieter
Modified: 2015-09-04 19:46 UTC (History)
3 users (show)

Fixed In Version: 5.0.0-2.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-09-04 19:46:26 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2015-04-19 21:42:39 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5-5.0.0-1.fc22.src.rpm
Description: Qt string template engine based on the Django template system
Fedora Account System Username: rdieter

Newer parallel-installable grantlee-qt5 (vs existing qt4-based grantlee package)

Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=9515721

Comment 1 Rex Dieter 2015-05-28 19:12:24 UTC
*** Bug 1226026 has been marked as a duplicate of this bug. ***

Comment 2 Rex Dieter 2015-08-08 21:15:13 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/grantlee-qt5-5.0.0-2.fc22.src.rpm

%changelog
* Sat Aug 08 2015 Rex Dieter <rdieter>  5.0.0-2
- update URL

Comment 3 Jan Grulich 2015-08-26 20:22:56 UTC
1) Typo in BuildRequires: qt5-tools-devel, should be qt5-qttools-devel
2) Use %license macro instead of %doc for the license file
3) Some python files are also under BSD license so maybe the license should be LGPLv2+ and BSD

Otherwise looks good, all mentioned issues are not blockers and can be simply fixed during import. Approved.

Comment 4 Rex Dieter 2015-08-28 15:04:36 UTC
New Package SCM Request
=======================
Package Name: grantlee-qt5
Short Description: Qt string template engine based on the Django template system
Upstream URL: https://github.com/steveire/grantlee
Owners: rdieter group::kde-sig 
Branches: f22 f23
InitialCC:

Comment 5 Gwyn Ciesla 2015-08-30 14:20:55 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2015-08-30 23:19:35 UTC
imported

Comment 7 Fedora Update System 2015-08-31 11:52:33 UTC
grantlee-qt5-5.0.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14650

Comment 8 Fedora Update System 2015-09-01 10:04:40 UTC
grantlee-qt5-5.0.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update grantlee-qt5'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14650

Comment 9 Fedora Update System 2015-09-04 19:46:25 UTC
grantlee-qt5-5.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.