Bug 1214034

Summary: After upgrade ks profile script are not visible
Product: [Community] Spacewalk Reporter: Stephen Herr <sherr>
Component: WebUIAssignee: Stephen Herr <sherr>
Status: CLOSED CURRENTRELEASE QA Contact: Red Hat Satellite QA List <satqe-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.3CC: caugello, cperry, ggainey, jdobes, satqe-list, tkasparek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: spacewalk-java-2.4.6-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1188586 Environment:
Last Closed: 2015-10-08 13:26:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1188586    
Bug Blocks: 1267654    

Description Stephen Herr 2015-04-21 19:41:57 UTC
+++ This bug was initially created as a clone of Bug #1188586 +++

Description of problem:

After upgrade ks scripts are visible but link is broken

How reproducible:


Steps to Reproduce:
1. Upgrade from 5.6 to 5.7
2. Go to Systems > Kickstart > Profile > Scripts


Actual results:
Script will be visible but not linking to script

Expected results:
Access to script

Additional info:

Current workaround is to check the page source and find the link :
~~~

 href=&quot;/rhn/kickstart/KickstartScriptEdit.do?kssid=2762&amp;ksid=2888
~~

Typing https://<satfqnd>/rhn/kickstart/KickstartScriptEdit.dokssid=2762&amp;ksid=2888 in the URL field of a browser, looking at a  form as in the uploaded picture, adding a Script Name and saving the HTML. Then it looks like this :
~~
                href=&quot;/rhn/kickstart/KickstartScriptEdit.do?kssid=2762&amp;ksid=2888&quot;&gt;
                    iptable.config   
~~~

--- Additional comment from Stephen Herr on 2015-04-21 14:34:50 EDT ---

Okay, for clarity:
The problem is better stated as "the Kickstart Scripts don't have names and therefore the link (who's url is correctly rendered in the source) has a zero-length visible text". Hopefully that will clear up some confusion.

Kickstart Scripts have required names since spacewalk-java-1.6.70-1 (after Sat 5.4, before Sat 5.5) so these customers must have upgraded from Sat 5.4 or earlier to be hitting this problem, and must have never touched these scripts since then.

The thing that has changed from Sat 5.6 -> Sat 5.7 is that in 5.6 there used to be two identical links to view the Kickstart Script, a "Script #" column that always had text like "Script 1", and a "Script Name" column that would display the script names. In Sat 5.7 there is only the "Script Name" column, so if the script doesn't have a name (because it was created before Sat 5.5) then there is nothing to display.

Requiring script names properly should have been part of the upgrade process from Sat 5.4 -> 5.5, but since we missed it and upgrades are particularly difficult to change after a release, probably the best fix to be had here is to teach Sat 5.7 to display some dummy string like "Script" if the script has no name.

Comment 1 Stephen Herr 2015-04-21 19:45:17 UTC
Committing to Spacewalk master:
0b20085cd8cd950d466f3f27b55a464180b63916

Comment 2 Jan Dobes 2015-10-08 13:26:46 UTC
Spacewalk 2.4 has been released.