Bug 1188586 - After upgrade ks profile script are not visible
Summary: After upgrade ks profile script are not visible
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite 5
Classification: Red Hat
Component: WebUI
Version: 570
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Stephen Herr
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks: sat570-triage 1214034
TreeView+ depends on / blocked
 
Reported: 2015-02-03 10:15 UTC by Christophe Augello
Modified: 2019-07-11 08:36 UTC (History)
6 users (show)

Fixed In Version: spacewalk-java-2.3.8-104
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1214034 (view as bug list)
Environment:
Last Closed: 2015-06-01 13:05:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (98.05 KB, image/png)
2015-02-03 10:15 UTC, Christophe Augello
no flags Details
ks scripts after upgrade (87.83 KB, image/png)
2015-03-30 13:10 UTC, Tomáš Kašpárek
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1040 0 normal SHIPPED_LIVE Red Hat Satellite bug fix update 2015-06-01 17:05:06 UTC

Description Christophe Augello 2015-02-03 10:15:20 UTC
Created attachment 987482 [details]
screenshot

Description of problem:

After upgrade ks scripts are visible but link is broken

How reproducible:


Steps to Reproduce:
1. Upgrade from 5.6 to 5.7
2. Go to Systems > Kickstart > Profile > Scripts


Actual results:
Script will be visible but not linking to script

Expected results:
Access to script

Additional info:

Current workaround is to check the page source and find the link :
~~~

 href="/rhn/kickstart/KickstartScriptEdit.do?kssid=2762&ksid=2888
~~

Typing https://<satfqnd>/rhn/kickstart/KickstartScriptEdit.dokssid=2762&amp;ksid=2888 in the URL field of a browser, looking at a  form as in the uploaded picture, adding a Script Name and saving the HTML. Then it looks like this :
~~
                href=&quot;/rhn/kickstart/KickstartScriptEdit.do?kssid=2762&amp;ksid=2888&quot;&gt;
                    iptable.config   
~~~

Comment 5 Tomáš Kašpárek 2015-03-30 13:10:19 UTC
Created attachment 1008470 [details]
ks scripts after upgrade

Comment 8 Stephen Herr 2015-04-21 18:34:50 UTC
Okay, for clarity:
The problem is better stated as "the Kickstart Scripts don't have names and therefore the link (who's url is correctly rendered in the source) has a zero-length visible text". Hopefully that will clear up some confusion.

Kickstart Scripts have required names since spacewalk-java-1.6.70-1 (after Sat 5.4, before Sat 5.5) so these customers must have upgraded from Sat 5.4 or earlier to be hitting this problem, and must have never touched these scripts since then.

The thing that has changed from Sat 5.6 -> Sat 5.7 is that in 5.6 there used to be two identical links to view the Kickstart Script, a "Script #" column that always had text like "Script 1", and a "Script Name" column that would display the script names. In Sat 5.7 there is only the "Script Name" column, so if the script doesn't have a name (because it was created before Sat 5.5) then there is nothing to display.

Requiring script names properly should have been part of the upgrade process from Sat 5.4 -> 5.5, but since we missed it and upgrades are particularly difficult to change after a release, probably the best fix to be had here is to teach Sat 5.7 to display some dummy string like "Script" if the script has no name.

Comment 10 Stephen Herr 2015-04-21 19:45:53 UTC
Committing to Spacewalk master:
0b20085cd8cd950d466f3f27b55a464180b63916

Comment 11 Stephen Herr 2015-05-06 18:41:40 UTC
e01bea8b53226ae6ed1d648fbd912e0393d67e35

Comment 13 Martin Korbel 2015-05-19 12:34:15 UTC
VERIFIED on spacewalk-java-2.3.8-105

Reproducer by comment 9.

WebUI shows text "Script" as name of script, if the name is missing.

Comment 15 errata-xmlrpc 2015-06-01 13:05:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1040.html


Note You need to log in before you can comment on or make changes to this bug.