Bug 1215575
| Summary: | Review Request: tangerine - Perl dependency metadata tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | tangerine-0.16-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-14 08:59:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 197295, 1215296 | ||
| Bug Blocks: | |||
|
Description
Petr Šabata
2015-04-27 07:30:59 UTC
This is the utility which used to a part of the perl-Tangerine package. It is now, beginning with v0.15, distributed separately. Reviewers, please note the `perl(Tangerine) >= 0.15' build-time dependency isn't strictly required. You can remove the version constraint when testing whether the package builds. Updated to 0.16. Spec URL: https://psabata.fedorapeople.org/pkgs/tangerine/tangerine.spec SRPM URL: https://psabata.fedorapeople.org/pkgs/tangerine/tangerine-0.16-1.fc21.src.rpm URL and Source0 are usable. Ok. Source archive is original (SHA-256: 7347a57170c6df323b79900568f184bd8572fd2322b55ece5ff638015a262490). Ok. TODO: Consider renaming the package to perl-App-Tangerine. It's not only a tangerine(1) tool. It also delivers Perl modules, so it's a Perl add-on <https://fedoraproject.org/wiki/Packaging:NamingGuidelines#AddonPerl>. License verified from Makefile.PL, LICENSE. Ok. Summary verified from README.md. Description is Ok. No XS code, noarch BuildArch is Ok. TODO: Constrain `perl(ExtUtils::MakeMaker)' build-time dependency with `>= 6.30' version (Makefile.PL:8). Test::Pod not used by tests. Ok. All build-time dependencies are specified. Ok. All tests pass. Ok. $ rpmlint tangerine.spec ../SRPMS/tangerine-0.16-1.fc23.src.rpm ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm tangerine.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal tangerine.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal tangerine.noarch: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal tangerine.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm -rwxr-xr-x 1 root root 1933 Apr 28 12:57 /usr/bin/tangerine drwxr-xr-x 2 root root 0 Apr 28 12:57 /usr/share/doc/tangerine -rw-r--r-- 1 root root 212 Apr 27 17:02 /usr/share/doc/tangerine/CONTRIBUTING -rw-r--r-- 1 root root 367 Apr 27 17:02 /usr/share/doc/tangerine/Changes -rw-r--r-- 1 root root 354 Apr 27 17:02 /usr/share/doc/tangerine/README.md drwxr-xr-x 2 root root 0 Apr 28 12:57 /usr/share/licenses/tangerine -rw-r--r-- 1 root root 1084 Apr 27 17:02 /usr/share/licenses/tangerine/LICENSE -rw-r--r-- 1 root root 2064 Apr 28 12:57 /usr/share/man/man1/tangerine.1.gz -rw-r--r-- 1 root root 1332 Apr 28 12:57 /usr/share/man/man3/App::Tangerine.3pm.gz -rw-r--r-- 1 root root 1411 Apr 28 12:57 /usr/share/man/man3/App::Tangerine::Metadata.3pm.gz drwxr-xr-x 2 root root 0 Apr 28 12:57 /usr/share/perl5/vendor_perl/App drwxr-xr-x 2 root root 0 Apr 28 12:57 /usr/share/perl5/vendor_perl/App/Tangerine -rw-r--r-- 1 root root 8728 Apr 27 17:02 /usr/share/perl5/vendor_perl/App/Tangerine.pm -rw-r--r-- 1 root root 1295 Apr 27 17:02 /usr/share/perl5/vendor_perl/App/Tangerine/Metadata.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 perl >= 1:5.010 1 perl(:MODULE_COMPAT_5.20.2) 1 perl(App::Tangerine) 1 perl(App::Tangerine::Metadata) 1 perl(Archive::Extract) 1 perl(Cwd) 1 perl(File::Find::Rule) 1 perl(File::Find::Rule::Perl) 1 perl(File::Spec) 1 perl(File::Temp) 1 perl(Getopt::Long) 1 perl(List::Compare) 1 perl(MCE::Map) 1 perl(overload) 1 perl(Pod::Usage) 1 perl(strict) 1 perl(Tangerine) >= 0.15 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm | sort -f | uniq -c 1 perl(App::Tangerine) = 0.16 1 perl(App::Tangerine::Metadata) = 0.16 1 tangerine = 0.16-1.fc23 Binary provides are Ok. Package build in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9585676). Ok. Otherwise this package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. New Package SCM Request ======================= Package Name: tangerine Short Description: Perl dependency metadata tool Upstream URL: http://search.cpan.org/dist/App-Tangerine/ Owners: psabata jplesnik ppisar Branches: el6 epel7 f20 f21 f22 InitialCC: perl-sig Git done (by process-git-requests). Thank you both. perl-Tangerine-0.15-1.fc22,tangerine-0.16-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-Tangerine-0.15-1.fc22,tangerine-0.16-1.fc22 perl-Tangerine-0.15-1.fc21,tangerine-0.16-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Tangerine-0.15-1.fc21,tangerine-0.16-1.fc21 perl-Tangerine-0.15-1.fc20,tangerine-0.16-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Tangerine-0.15-1.fc20,tangerine-0.16-1.fc20 perl-List-Compare-0.49-1.el7,perl-Tangerine-0.15-1.el7,tangerine-0.16-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-List-Compare-0.49-1.el7,perl-Tangerine-0.15-1.el7,tangerine-0.16-1.el7 perl-List-Compare-0.49-1.el6,perl-Tangerine-0.15-1.el6,tangerine-0.16-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-List-Compare-0.49-1.el6,perl-Tangerine-0.15-1.el6,tangerine-0.16-1.el6 tangerine-0.16-1.fc22, perl-Tangerine-0.15-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. perl-Tangerine-0.15-1.fc20, tangerine-0.16-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. perl-Tangerine-0.15-1.fc21, tangerine-0.16-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. EPEL updates submitted for stable today. perl-Tangerine-0.15-1.el7, perl-List-Compare-0.49-1.el7, tangerine-0.16-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. perl-List-Compare-0.49-1.el6, perl-Tangerine-0.15-1.el6, tangerine-0.16-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |