Bug 1215575 - Review Request: tangerine - Perl dependency metadata tool
Summary: Review Request: tangerine - Perl dependency metadata tool
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 197295 1215296
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-27 07:30 UTC by Petr Šabata
Modified: 2015-05-14 20:05 UTC (History)
2 users (show)

Fixed In Version: tangerine-0.16-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 08:59:43 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2015-04-27 07:30:59 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/tangerine/tangerine.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/tangerine/tangerine-0.15-1.fc21.src.rpm
Description:
A perl dependency metadata reporting tool built on top of Tangerine.
Fedora Account System Username: psabata

Comment 1 Petr Šabata 2015-04-27 07:34:08 UTC
This is the utility which used to a part of the perl-Tangerine package.  It is now, beginning with v0.15, distributed separately.

Reviewers, please note the `perl(Tangerine) >= 0.15' build-time dependency isn't strictly required.  You can remove the version constraint when testing whether the package builds.

Comment 3 Petr Pisar 2015-04-28 11:26:27 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 7347a57170c6df323b79900568f184bd8572fd2322b55ece5ff638015a262490). Ok.

TODO: Consider renaming the package to perl-App-Tangerine. It's not only a tangerine(1) tool. It also delivers Perl modules, so it's a Perl add-on <https://fedoraproject.org/wiki/Packaging:NamingGuidelines#AddonPerl>.

License verified from Makefile.PL, LICENSE. Ok.
Summary verified from README.md.
Description is Ok.
No XS code, noarch BuildArch is Ok.

TODO: Constrain `perl(ExtUtils::MakeMaker)' build-time dependency with `>= 6.30' version (Makefile.PL:8).

Test::Pod not used by tests. Ok.

All build-time dependencies are specified. Ok.
All tests pass. Ok.

$ rpmlint tangerine.spec ../SRPMS/tangerine-0.16-1.fc23.src.rpm ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm 
tangerine.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal
tangerine.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
tangerine.noarch: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal
tangerine.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm 
-rwxr-xr-x    1 root    root                     1933 Apr 28 12:57 /usr/bin/tangerine
drwxr-xr-x    2 root    root                        0 Apr 28 12:57 /usr/share/doc/tangerine
-rw-r--r--    1 root    root                      212 Apr 27 17:02 /usr/share/doc/tangerine/CONTRIBUTING
-rw-r--r--    1 root    root                      367 Apr 27 17:02 /usr/share/doc/tangerine/Changes
-rw-r--r--    1 root    root                      354 Apr 27 17:02 /usr/share/doc/tangerine/README.md
drwxr-xr-x    2 root    root                        0 Apr 28 12:57 /usr/share/licenses/tangerine
-rw-r--r--    1 root    root                     1084 Apr 27 17:02 /usr/share/licenses/tangerine/LICENSE
-rw-r--r--    1 root    root                     2064 Apr 28 12:57 /usr/share/man/man1/tangerine.1.gz
-rw-r--r--    1 root    root                     1332 Apr 28 12:57 /usr/share/man/man3/App::Tangerine.3pm.gz
-rw-r--r--    1 root    root                     1411 Apr 28 12:57 /usr/share/man/man3/App::Tangerine::Metadata.3pm.gz
drwxr-xr-x    2 root    root                        0 Apr 28 12:57 /usr/share/perl5/vendor_perl/App
drwxr-xr-x    2 root    root                        0 Apr 28 12:57 /usr/share/perl5/vendor_perl/App/Tangerine
-rw-r--r--    1 root    root                     8728 Apr 27 17:02 /usr/share/perl5/vendor_perl/App/Tangerine.pm
-rw-r--r--    1 root    root                     1295 Apr 27 17:02 /usr/share/perl5/vendor_perl/App/Tangerine/Metadata.pm
File permissions and layout is Ok.
$ rpm -q --requires -p ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm | sort -f | uniq -c
      1 /usr/bin/perl
      1 perl >= 1:5.010
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(App::Tangerine)
      1 perl(App::Tangerine::Metadata)
      1 perl(Archive::Extract)
      1 perl(Cwd)
      1 perl(File::Find::Rule)
      1 perl(File::Find::Rule::Perl)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(Getopt::Long)
      1 perl(List::Compare)
      1 perl(MCE::Map)
      1 perl(overload)
      1 perl(Pod::Usage)
      1 perl(strict)
      1 perl(Tangerine) >= 0.15
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/tangerine-0.16-1.fc23.noarch.rpm | sort -f | uniq -c
      1 perl(App::Tangerine) = 0.16
      1 perl(App::Tangerine::Metadata) = 0.16
      1 tangerine = 0.16-1.fc23
Binary provides are Ok.

Package build in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9585676). Ok.

Otherwise this package is in line with Fedora and Perl packaging guidelines.

Please consider fixing `TODO' items before building this package.
Resolution: Package APPROVED.

Comment 4 Petr Šabata 2015-04-28 11:30:21 UTC
New Package SCM Request
=======================
Package Name: tangerine
Short Description: Perl dependency metadata tool
Upstream URL: http://search.cpan.org/dist/App-Tangerine/
Owners: psabata jplesnik ppisar
Branches: el6 epel7 f20 f21 f22
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-04-28 13:04:58 UTC
Git done (by process-git-requests).

Comment 6 Petr Šabata 2015-04-28 13:47:16 UTC
Thank you both.

Comment 7 Fedora Update System 2015-04-28 15:01:21 UTC
perl-Tangerine-0.15-1.fc22,tangerine-0.16-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/perl-Tangerine-0.15-1.fc22,tangerine-0.16-1.fc22

Comment 8 Fedora Update System 2015-04-28 15:03:30 UTC
perl-Tangerine-0.15-1.fc21,tangerine-0.16-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Tangerine-0.15-1.fc21,tangerine-0.16-1.fc21

Comment 9 Fedora Update System 2015-04-28 15:07:16 UTC
perl-Tangerine-0.15-1.fc20,tangerine-0.16-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Tangerine-0.15-1.fc20,tangerine-0.16-1.fc20

Comment 10 Fedora Update System 2015-04-29 10:42:55 UTC
perl-List-Compare-0.49-1.el7,perl-Tangerine-0.15-1.el7,tangerine-0.16-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-List-Compare-0.49-1.el7,perl-Tangerine-0.15-1.el7,tangerine-0.16-1.el7

Comment 11 Fedora Update System 2015-04-29 10:54:39 UTC
perl-List-Compare-0.49-1.el6,perl-Tangerine-0.15-1.el6,tangerine-0.16-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-List-Compare-0.49-1.el6,perl-Tangerine-0.15-1.el6,tangerine-0.16-1.el6

Comment 12 Fedora Update System 2015-05-08 07:42:10 UTC
tangerine-0.16-1.fc22, perl-Tangerine-0.15-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-05-10 23:45:14 UTC
perl-Tangerine-0.15-1.fc20, tangerine-0.16-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-05-10 23:49:20 UTC
perl-Tangerine-0.15-1.fc21, tangerine-0.16-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Petr Šabata 2015-05-14 08:59:43 UTC
EPEL updates submitted for stable today.

Comment 16 Fedora Update System 2015-05-14 20:04:23 UTC
perl-Tangerine-0.15-1.el7, perl-List-Compare-0.49-1.el7, tangerine-0.16-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-05-14 20:05:05 UTC
perl-List-Compare-0.49-1.el6, perl-Tangerine-0.15-1.el6, tangerine-0.16-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.