Bug 1216210
| Summary: | Service Dialogs, automatically call dialog_parser method from catalogiteminitialization/catalogbundleinitialization | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Tina Fitzgerald <tfitzger> |
| Component: | Automate | Assignee: | Tina Fitzgerald <tfitzger> |
| Status: | CLOSED ERRATA | QA Contact: | Shveta <sshveta> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.4.0 | CC: | jhardy, jprause, mfeifer, mkanoor, obarenbo, tfitzger |
| Target Milestone: | GA | ||
| Target Release: | 5.4.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-06-16 13:00:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
PR created: https://github.com/ManageIQ/manageiq/pull/2783 New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/15d02c768ee8d4521777af409116edf7d23b1b9c commit 15d02c768ee8d4521777af409116edf7d23b1b9c Author: Tina Fitzgerald <tfitzger> AuthorDate: Tue Apr 28 15:42:21 2015 -0400 Commit: Tina Fitzgerald <tfitzger> CommitDate: Wed May 13 15:58:11 2015 -0400 Add call to instantiate dialog options if parsed dialog options are not found. https://bugzilla.redhat.com/show_bug.cgi?id=1216210 .../__methods__/catalogbundleinitialization.rb | 17 +++++++++++------ .../__methods__/catalogiteminitialization.rb | 17 ++++++++++++----- 2 files changed, 23 insertions(+), 11 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=77cf4343cbbaa550d925468cd9afbb87ad1709a5 commit 77cf4343cbbaa550d925468cd9afbb87ad1709a5 Author: Tina Fitzgerald <tfitzger> AuthorDate: Tue Apr 28 15:42:21 2015 -0400 Commit: Tina Fitzgerald <tfitzger> CommitDate: Thu May 14 15:34:40 2015 -0400 Add call to instantiate dialog options if parsed dialog options are not found. https://bugzilla.redhat.com/show_bug.cgi?id=1216210 .../__methods__/catalogbundleinitialization.rb | 17 +++++++++++------ .../__methods__/catalogiteminitialization.rb | 17 ++++++++++++----- 2 files changed, 23 insertions(+), 11 deletions(-) Dialog parser is called in pre1 value of catalogiteminitialization and catalogbundleinitialization. /Service/Provisioning/StateMachines/Methods/DialogParser Verified in 5.4.0.0.26.20150511144816_f924bd4 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1100.html |
Description of problem: Recent service dialog enhancements introduced a new automate method to do all of the dialog parsing as opposed to having the catalogiteminitialization and catalogbundleinitialization methods each do their own dialog parsing. This new dialog_parser method should be called in a statemachine step prior to the catalogiteminitialization and catalogbubleinitialization automate methods. Backwards compatibility is a concern here because of the necessary configuration changes and the heavy use of these service instances and methods. To resolve the backwards compatibility issue.... The catalogiteminitialization/catalogbundleinitialization automate methods should call: $evm.instantiate('/Service/Provisioning/StateMachines/Methods/DialogParser') if the parsed dialog information is not available. This change should be very successful because the dialog_parser method and instance are shipped with the new catalogiteminitialization and catalogbundleinitialization methods.