Bug 1216210 - Service Dialogs, automatically call dialog_parser method from catalogiteminitialization/catalogbundleinitialization
Summary: Service Dialogs, automatically call dialog_parser method from catalogiteminit...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.4.0
Assignee: Tina Fitzgerald
QA Contact: Shveta
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-28 18:51 UTC by Tina Fitzgerald
Modified: 2015-06-16 13:00 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-16 13:00:30 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description Tina Fitzgerald 2015-04-28 18:51:14 UTC
Description of problem:

Recent service dialog enhancements introduced a new automate method to do all of the dialog parsing as opposed to having the catalogiteminitialization and catalogbundleinitialization methods each do their own dialog parsing. This new dialog_parser method should be called in a statemachine step prior to the catalogiteminitialization and catalogbubleinitialization automate methods.

Backwards compatibility is a concern here because of the necessary configuration changes and the heavy use of these service instances and methods.

To resolve the backwards compatibility issue....
The catalogiteminitialization/catalogbundleinitialization automate methods should call:    
$evm.instantiate('/Service/Provisioning/StateMachines/Methods/DialogParser')
if the parsed dialog information is not available.

This change should be very successful because the dialog_parser method and instance are shipped with the new catalogiteminitialization and catalogbundleinitialization methods.

Comment 2 Tina Fitzgerald 2015-04-29 20:46:59 UTC
PR created:
https://github.com/ManageIQ/manageiq/pull/2783

Comment 3 CFME Bot 2015-05-14 18:20:43 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/15d02c768ee8d4521777af409116edf7d23b1b9c

commit 15d02c768ee8d4521777af409116edf7d23b1b9c
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Tue Apr 28 15:42:21 2015 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Wed May 13 15:58:11 2015 -0400

    Add call to instantiate dialog options if parsed dialog options are
    not found.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1216210

 .../__methods__/catalogbundleinitialization.rb          | 17 +++++++++++------
 .../__methods__/catalogiteminitialization.rb            | 17 ++++++++++++-----
 2 files changed, 23 insertions(+), 11 deletions(-)

Comment 5 CFME Bot 2015-05-14 22:20:18 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=77cf4343cbbaa550d925468cd9afbb87ad1709a5

commit 77cf4343cbbaa550d925468cd9afbb87ad1709a5
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Tue Apr 28 15:42:21 2015 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Thu May 14 15:34:40 2015 -0400

    Add call to instantiate dialog options if parsed dialog options are
    not found.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1216210

 .../__methods__/catalogbundleinitialization.rb          | 17 +++++++++++------
 .../__methods__/catalogiteminitialization.rb            | 17 ++++++++++++-----
 2 files changed, 23 insertions(+), 11 deletions(-)

Comment 7 Shveta 2015-05-18 21:44:06 UTC
Dialog parser is called in pre1 value of catalogiteminitialization and catalogbundleinitialization.

/Service/Provisioning/StateMachines/Methods/DialogParser

Verified in 5.4.0.0.26.20150511144816_f924bd4

Comment 9 errata-xmlrpc 2015-06-16 13:00:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.