Bug 1219787

Summary:	package glupy as a subpackage under gluster namespace.
Product:	[Community] GlusterFS	Reporter:	Humble Chirammal <hchiramm>
Component:	packaging	Assignee:	Humble Chirammal <hchiramm>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	urgent
Version:	3.7.0	CC:	bugs, gluster-bugs, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1211900	Environment:
Last Closed:	2015-05-14 17:29:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1211848, 1211900, 1220022
Bug Blocks:	1199352

Description Humble Chirammal 2015-05-08 09:22:36 UTC

+++ This bug was initially created as a clone of Bug #1211900 +++

Description of problem:


Currently glupy files resides in gluster namespace of python site packages. The other projects like libgfapi-python ..etc are evolving and need to share the gluster namespace. The current structure makes things difficult as all subpackages have its __init__ files and other files. One subpackage can not any more own gluster namespace. 

The attempt is to make below structure for gluster namespace so that it is more portable and scalable for future use. 

  <sitepackages>/gluster/
                         |
                         -- __init__.py
                         |   
                         |
                         -- glupy
                                 | 
                                 -- __init__.py
                                 -- glupy.py
                                 -- ........
                         |
                         |
                         -- gfapi            
                                 |
                                  -- __init__.py
                                  -- gfapi.py
                                  -- ........

By above structure clients can import:

 >>> from gluster import glupy
 >>> from gluster import gfapi
                         
libgfapi-python project has been moved to this structure via 

http://review.gluster.org/#/c/9668/       
                             
Version-Release number of selected component (if applicable):

GlusterFS 3.7

How reproducible:

N/A


Steps to Reproduce:

N/A

Actual results:

glupy is not a subpackage under gluster namespace.

Expected results:

glupy should be packaged as a subpackage under gluster namespace.

--- Additional comment from Anand Avati on 2015-04-15 04:05:46 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-15 10:59:42 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-28 15:23:38 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-29 02:52:43 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-05-04 06:15:23 EDT ---

COMMIT: http://review.gluster.org/10248 committed in master by Niels de Vos (ndevos) 
------
commit 40df2ed4d098d4cd2c6abbed23e497ac3e2e5804
Author: Humble Devassy Chirammal <hchiramm>
Date:   Wed Apr 15 13:30:34 2015 +0530

    glupy: package glupy as a subpackage under gluster namespace
    
    Currently glupy files resides in gluster namespace of python site packages.
    The other projects like libgfapi-python ..etc are evolving and need to share
    the gluster namespace. The current structure makes things difficult as all
    subpackages have its own __init__ files and other files.
    One subpackage can not any more own gluster namespace.
    
    The attempt is to make below structure for gluster namespace so that
    it is more portable and scalable for future use.
    
      <sitepackages>/gluster/
                             |
                             -- __init__.py
                             |
                             |
                             -- glupy
                                     |
                                     -- __init__.py
                                     -- glupy.py
                                     -- ........
                             |
                             |
                             -- gfapi
                                     |
                                      -- __init__.py
                                      -- gfapi.py
                                      -- ........
    
    By above structure clients can import:
    
     >>> from gluster import glupy
     >>> from gluster import gfapi
    
    libgfapi-python project has been moved to this structure via
    
    http://review.gluster.org/#/c/9668/
    
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    
    Change-Id: I54886200ddb6a4153a74d9e187aeca7cad79ef9e
    BUG: 1211900
    Reviewed-on: http://review.gluster.org/10248
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 1 Anand Avati 2015-05-08 19:17:08 UTC

COMMIT: http://review.gluster.org/10689 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 21c75d600be759003102983b48bb75f0f02e7ef6
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Fri May 8 13:16:06 2015 -0400

    build: RPM build fails (make -C extras/LinuxRPM glusterrpms)
    
    minor typo in glusterfs.spec.in prevents building RPMS
    
    Change-Id: I876943e256d393921009d75cab84944f420632ba
    BUG: 1219787
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/10689
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>

Comment 2 Anand Avati 2015-05-08 21:31:10 UTC

COMMIT: http://review.gluster.org/10672 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 135e0fb4f312f59b36da8307b55c2a240d97ba05
Author: Humble Devassy Chirammal <hchiramm>
Date:   Wed Apr 15 12:29:16 2015 +0530

    build: Introducing  python-gluster package
    
    Currently the gluster namespace/module is owned by glusterfs-api rpm.
    Because of this, other packages (extra-xlators or libgfapi-python)
    have to depend on glusterfs-api to get the gluster namespace. The gluster
    namespace should be owned by a core package.This patch introduce new package
    called python-gluster and moves the ownership of gluster module
    to python-gluster.
    
    Cherry picked from commit cf1c53343d4b6fe834833b76c50c61fd8a312de0:
    > Change-Id: Ib75ab922736f3bea6355da4d8dbec3a08b2844d5
    > BUG: 1211848
    > Signed-off-by: Humble Devassy Chirammal <hchiramm>
    > Reviewed-on: http://review.gluster.org/10244
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Niels de Vos <ndevos>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    
    Change-Id: Ib75ab922736f3bea6355da4d8dbec3a08b2844d5
    BUG: 1219787
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/10672
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Anand Avati 2015-05-11 20:37:39 UTC

REVIEW: http://review.gluster.org/10754 (rpm: fix dependency on python-gluster) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 4 Anand Avati 2015-05-12 12:13:14 UTC

COMMIT: http://review.gluster.org/10754 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit c1cd4fa709ed3f997450d57c07238b4356a14607
Author: Niels de Vos <ndevos>
Date:   Mon May 11 22:34:59 2015 +0200

    rpm: fix dependency on python-gluster
    
    The glusterfs-extra-xlators tries to install python-glusterfs. This is
    incorrect, the package is called python-gluster.
    
    Cherry picked from commit 5388706e8431114418c0335f24532bf9f8df7588:
    > BUG: 1211848
    > Change-Id: Id48a63ebe893c2bab90fab37ea3e32e601fae0fa
    > Reported-by: Meni Yakove <myakove>
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/10508
    > Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    > Tested-by: NetBSD Build System
    > Tested-by: Gluster Build System <jenkins.com>
    
    Change-Id: Id48a63ebe893c2bab90fab37ea3e32e601fae0fa
    BUG: 1219787
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/10754
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Gaurav Kumar Garg <ggarg>

Comment 5 Niels de Vos 2015-05-14 17:29:40 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:36:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:38:23 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:47:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user