Bug 1220022 - package glupy as a subpackage under gluster namespace.
Summary: package glupy as a subpackage under gluster namespace.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: packaging
Version: 3.7.0
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On: 1211900
Blocks: 1219787
TreeView+ depends on / blocked
 
Reported: 2015-05-09 08:03 UTC by Humble Chirammal
Modified: 2015-05-14 17:47 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1211900
Environment:
Last Closed: 2015-05-14 17:29:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Humble Chirammal 2015-05-09 08:03:45 UTC
+++ This bug was initially created as a clone of Bug #1211900 +++

Description of problem:


Currently glupy files resides in gluster namespace of python site packages. The other projects like libgfapi-python ..etc are evolving and need to share the gluster namespace. The current structure makes things difficult as all subpackages have its __init__ files and other files. One subpackage can not any more own gluster namespace. 

The attempt is to make below structure for gluster namespace so that it is more portable and scalable for future use. 

  <sitepackages>/gluster/
                         |
                         -- __init__.py
                         |   
                         |
                         -- glupy
                                 | 
                                 -- __init__.py
                                 -- glupy.py
                                 -- ........
                         |
                         |
                         -- gfapi            
                                 |
                                  -- __init__.py
                                  -- gfapi.py
                                  -- ........

By above structure clients can import:

 >>> from gluster import glupy
 >>> from gluster import gfapi
                         
libgfapi-python project has been moved to this structure via 

http://review.gluster.org/#/c/9668/       
                             
Version-Release number of selected component (if applicable):

GlusterFS 3.7

How reproducible:

N/A


Steps to Reproduce:

N/A

Actual results:

glupy is not a subpackage under gluster namespace.

Expected results:

glupy should be packaged as a subpackage under gluster namespace.

--- Additional comment from Anand Avati on 2015-04-15 04:05:46 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-15 10:59:42 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-28 15:23:38 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-29 02:52:43 EDT ---

REVIEW: http://review.gluster.org/10248 (glupy: package glupy as a subpackage under gluster namespace) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-05-04 06:15:23 EDT ---

COMMIT: http://review.gluster.org/10248 committed in master by Niels de Vos (ndevos) 
------
commit 40df2ed4d098d4cd2c6abbed23e497ac3e2e5804
Author: Humble Devassy Chirammal <hchiramm>
Date:   Wed Apr 15 13:30:34 2015 +0530

    glupy: package glupy as a subpackage under gluster namespace
    
    Currently glupy files resides in gluster namespace of python site packages.
    The other projects like libgfapi-python ..etc are evolving and need to share
    the gluster namespace. The current structure makes things difficult as all
    subpackages have its own __init__ files and other files.
    One subpackage can not any more own gluster namespace.
    
    The attempt is to make below structure for gluster namespace so that
    it is more portable and scalable for future use.
    
      <sitepackages>/gluster/
                             |
                             -- __init__.py
                             |
                             |
                             -- glupy
                                     |
                                     -- __init__.py
                                     -- glupy.py
                                     -- ........
                             |
                             |
                             -- gfapi
                                     |
                                      -- __init__.py
                                      -- gfapi.py
                                      -- ........
    
    By above structure clients can import:
    
     >>> from gluster import glupy
     >>> from gluster import gfapi
    
    libgfapi-python project has been moved to this structure via
    
    http://review.gluster.org/#/c/9668/
    
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    
    Change-Id: I54886200ddb6a4153a74d9e187aeca7cad79ef9e
    BUG: 1211900
    Reviewed-on: http://review.gluster.org/10248
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

--- Additional comment from Anand Avati on 2015-05-08 13:18:16 EDT ---

REVIEW: http://review.gluster.org/10689 (build: RPM build fails (make -C extras/LinuxRPM glusterrpms)) posted (#1) for review on release-3.7 by Kaleb KEITHLEY (kkeithle)

Comment 1 Anand Avati 2015-05-09 08:39:15 UTC
REVIEW: http://review.gluster.org/10706 (glupy: package glupy as a subpackage under gluster namespace) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2015-05-09 13:37:17 UTC
COMMIT: http://review.gluster.org/10706 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 972458a74780923e7e867b9362dda1830eeefe5e
Author: Niels de Vos <ndevos>
Date:   Sat May 9 10:28:12 2015 +0200

    glupy: package glupy as a subpackage under gluster namespace
    
    Currently glupy files resides in gluster namespace of python site packages.
    The other projects like libgfapi-python ..etc are evolving and need to share
    the gluster namespace. The current structure makes things difficult as all
    subpackages have its own __init__ files and other files.
    One subpackage can not any more own gluster namespace.
    
    The attempt is to make below structure for gluster namespace so that
    it is more portable and scalable for future use.
    
      <sitepackages>/gluster/
                             |
                             -- __init__.py
                             |
                             |
                             -- glupy
                                     |
                                     -- __init__.py
                                     -- glupy.py
                                     -- ........
                             |
                             |
                             -- gfapi
                                     |
                                      -- __init__.py
                                      -- gfapi.py
                                      -- ........
    
    By above structure clients can import:
    
     >>> from gluster import glupy
     >>> from gluster import gfapi
    
    libgfapi-python project has been moved to this structure via
    
    http://review.gluster.org/#/c/9668/
    
    Cherry picked from commit 40df2ed4d098d4cd2c6abbed23e497ac3e2e5804:
    > Change-Id: I54886200ddb6a4153a74d9e187aeca7cad79ef9e
    > BUG: 1211900
    > Signed-off-by: Humble Devassy Chirammal <hchiramm>
    > Reviewed-on: http://review.gluster.org/10248
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Niels de Vos <ndevos>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    
    This backport is really minimal, because commit 44036808 removed the
    need for the changes in the glusterfs.spec.in file.
    
    Change-Id: I54886200ddb6a4153a74d9e187aeca7cad79ef9e
    BUG: 1220022
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/10706
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2015-05-14 17:29:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:36:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:23 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:47:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.