Bug 1220020

Summary: status.brick memory allocation failure.
Product: [Community] GlusterFS Reporter: Humble Chirammal <hchiramm>
Component: glusterdAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3.7.0CC: bugs, gluster-bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1211594 Environment:
Last Closed: 2015-05-15 17:10:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1211594    
Bug Blocks:    

Description Humble Chirammal 2015-05-09 07:27:11 UTC 
+++ This bug was initially created as a clone of Bug #1211594 +++

Description of problem:

At current stage, there is no memory allocation failure check on status.brick which can cause issues later in the error path. 


status.brick = GF_CALLOC (1, PATH_MAX + 256, gf_common_mt_strdup);
switch (cmd & GF_CLI_STATUS_MASK) 

{	switch (cmd & GF_CLI_STATUS_MASK) {
....

Version-Release number of selected component (if applicable):

GlusterFS 3.6.2

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

The memory allocation success/failure is not respected in current code.


Expected results:

The proper error code has to be returned if there is a failure.

Additional info:

--- Additional comment from Anand Avati on 2015-04-14 14:38:01 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-15 03:20:32 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-15 12:21:05 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#6) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-15 23:43:57 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#7) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-16 12:36:53 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#8) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-17 00:39:14 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not enough memory) posted (#9) for review on master by Humble Devassy Chirammal (humble.devassy)

--- Additional comment from Anand Avati on 2015-04-25 10:26:46 EDT ---

COMMIT: http://review.gluster.org/10144 committed in master by Vijay Bellur (vbellur) 
------
commit f6e24fc54453669f3943e50f44cce9bb6070a71a
Author: Humble Devassy Chirammal <hchiramm>
Date:   Tue Apr 7 11:27:19 2015 +0530

    cli: Error out when there is not enough memory
    
    Change-Id: Ia8d061de5be1343cc10a945f6cf011686a770d33
    BUG: 1211594
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/10144
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

--- Additional comment from Anand Avati on 2015-05-08 23:30:44 EDT ---

REVIEW: http://review.gluster.org/10674 (cli: Error out when there is not enough memory) posted (#2) for review on release-3.7 by Humble Devassy Chirammal (humble.devassy)
Comment 1 Anand Avati 2015-05-09 07:27:35 UTC 
REVIEW: http://review.gluster.org/10674 (cli: Error out when there is not enough memory) posted (#3) for review on release-3.7 by Humble Devassy Chirammal (humble.devassy)
Comment 2 Anand Avati 2015-05-09 07:32:01 UTC 
COMMIT: http://review.gluster.org/10674 committed in release-3.7 by Kaushal M (kaushal) 
------
commit 1c2ebcddb0e7e72ca40bae07419afbe958dfa60a
Author: Humble Devassy Chirammal <hchiramm>
Date:   Tue Apr 7 11:27:19 2015 +0530

    cli: Error out when there is not enough memory
    
    Change-Id: Ia8d061de5be1343cc10a945f6cf011686a770d33
    BUG: 1220020
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/10144
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>
    (cherry picked from commit f6e24fc54453669f3943e50f44cce9bb6070a71a)
    Reviewed-on: http://review.gluster.org/10674
    Reviewed-by: Kaushal M <kaushal>
    Tested-by: Kaushal M <kaushal>
Comment 3 Niels de Vos 2015-05-15 17:10:10 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user