Bug 1222148

Summary: usage text is wrong for use-readdirp mount default
Product: [Community] GlusterFS Reporter: Joe Julian <joe>
Component: fuseAssignee: bugs <bugs>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.6.3CC: bugs, hgowtham
Target Milestone: ---Keywords: EasyFix, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1222915 (view as bug list) Environment:
Last Closed: 2016-08-30 12:46:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1222915, 1384345    
Bug Blocks:    

Description Joe Julian 2015-05-15 21:40:50 UTC
glusterfsd/src/glusterfsd.c:215
        {"use-readdirp", ARGP_FUSE_USE_READDIRP_KEY, "BOOL", OPTION_ARG_OPTIONAL,
         "Use readdirp mode in fuse kernel module"
         " [default: \"off\"]"},


glusterfsd/src/glusterfsd.c:1077
        case ARGP_FUSE_USE_READDIRP_KEY:
                if (!arg)
                        arg = "yes";


The default should be yes anyway, so just need to fix the text in line 217

Even better would be to have these kind of options and their help text come from each translator's volume_options struct so changes don't come from multiple places. Perhaps that struct should be in include files?