Bug 1384345 - usage text is wrong for use-readdirp mount default
Summary: usage text is wrong for use-readdirp mount default
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: fuse
Version: 3.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: ankit
QA Contact:
URL:
Whiteboard:
: 1384323 (view as bug list)
Depends On: 1222915
Blocks: 1222148 1222917
TreeView+ depends on / blocked
 
Reported: 2016-10-13 07:45 UTC by ankit
Modified: 2016-11-29 09:36 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8.6
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1222915
Environment:
Last Closed: 2016-11-29 09:34:28 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description ankit 2016-10-13 07:45:59 UTC
+++ This bug was initially created as a clone of Bug #1222915 +++

+++ This bug was initially created as a clone of Bug #1222148 +++

glusterfsd/src/glusterfsd.c:215
        {"use-readdirp", ARGP_FUSE_USE_READDIRP_KEY, "BOOL", OPTION_ARG_OPTIONAL,
         "Use readdirp mode in fuse kernel module"
         " [default: \"off\"]"},


glusterfsd/src/glusterfsd.c:1077
        case ARGP_FUSE_USE_READDIRP_KEY:
                if (!arg)
                        arg = "yes";


The default should be yes anyway, so just need to fix the text in line 217

Even better would be to have these kind of options and their help text come from each translator's volume_options struct so changes don't come from multiple places. Perhaps that struct should be in include files?

--- Additional comment from Vijay Bellur on 2016-06-02 17:02:58 EDT ---

REVIEW: http://review.gluster.org/14622 (Corrected default text for ARGP_FUSE_USE_READDIRP_KEY Changed from "off" to "yes" per BZ 1222915) posted (#1) for review on master by Dustin Black (dblack)

--- Additional comment from Dustin Black on 2016-06-02 17:05:30 EDT ---

http://review.gluster.org/#/c/14622/

--- Additional comment from Vijay Bellur on 2016-06-06 11:01:45 EDT ---

COMMIT: http://review.gluster.org/14622 committed in master by Jeff Darcy (jdarcy) 
------
commit 66cc92c25ec2680e50a6b3edda2e027635c380db
Author: Dustin Black <dblack>
Date:   Thu Jun 2 17:01:32 2016 -0400

    Corrected default text for ARGP_FUSE_USE_READDIRP_KEY
    Changed from "off" to "yes" per BZ 1222915
    
    Change-Id: Idffffee621560adb4cc02c1001d1ae21ca11941f
    BUG: 1222915
    Signed-off-by: Dustin Black <dblack>
    Reviewed-on: http://review.gluster.org/14622
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 ankit 2016-10-13 08:05:41 UTC
*** Bug 1384323 has been marked as a duplicate of this bug. ***

Comment 2 Worker Ant 2016-10-13 09:20:10 UTC
REVIEW: http://review.gluster.org/15635 (fuse:  usage text is wrong for use-readdirp mount default) posted (#1) for review on release-3.8 by ankitraj

Comment 3 Worker Ant 2016-10-13 10:19:11 UTC
REVIEW: http://review.gluster.org/15635 (fuse:  usage text is wrong for use-readdirp mount default) posted (#2) for review on release-3.8 by ankitraj

Comment 4 Worker Ant 2016-10-18 07:02:29 UTC
COMMIT: http://review.gluster.org/15635 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit d552cdc8d1242d82b9e691726bede9bfe87fa726
Author: Ankit Raj <anraj>
Date:   Thu Oct 13 14:43:23 2016 +0530

    fuse:  usage text is wrong for use-readdirp mount default
    
    Backport of http://review.gluster.org/#/c/14622/
    
    Change-Id: I0020cd1862a9af11898813b6b31bd7f9125936d2
    Bug: 1384345
    Signed-off-by: Ankit Raj <anraj>
    Reviewed-on: http://review.gluster.org/15635
    Tested-by: ankitraj
    Reviewed-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 5 Niels de Vos 2016-11-29 09:36:04 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.6, please open a new bug report.

glusterfs-3.8.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2016-November/000217.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.