Bug 1223937

Summary: Outdated autotools helper config.* files
Product: [Community] GlusterFS Reporter: Patrick Matthäi <pmatthaei>
Component: buildAssignee: Kaleb KEITHLEY <kkeithle>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, kkeithle, ndevos
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.8.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1339192 (view as bug list) Environment:
Last Closed: 2016-06-16 12:31:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1339192    
Attachments:
Description Flags
updated config.guess file
none
updated config.sub file none

Description Patrick Matthäi 2015-05-21 18:26:31 UTC
Created attachment 1028349 [details]
updated config.guess file

Hi,

your config.{guess,sub} files are from 2009-11-20 and outdated, which also means that support for newer ports is missing.
I have attached more up to date versions.

Comment 1 Patrick Matthäi 2015-05-21 18:26:56 UTC
Created attachment 1028350 [details]
updated config.sub file

Comment 2 Kaleb KEITHLEY 2015-05-29 17:46:34 UTC
Our sources don't actually have config.guess and config.sub.

Our jenkins release task clones the source, runs ./autogen.sh (where config.{guess,sub} come from) and ./configure, before running `make dist` to product the release glusterfs-X.Y.Z.tar.gz.

The config.{guess,sub} in the tar file come from the archaic autoconf in CentOS 6.3, which is what the glusterfs jenkins is running on. We are working on updating both jenkins and the platform it runs on.

Even so, we should not be shipping the (arbitrary, old) config.{guess,sub} files from our jenkins machine.

Comment 3 Anand Avati 2015-05-29 17:49:47 UTC
REVIEW: http://review.gluster.org/11009 (build: outdated autotools helper config.* files in dist tarfile) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 4 Anand Avati 2015-05-30 09:41:09 UTC
REVIEW: http://review.gluster.org/11009 (build: outdated autotools helper config.* files in dist tarfile) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 5 Vijay Bellur 2016-05-23 10:35:58 UTC
REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 6 Vijay Bellur 2016-05-23 11:47:33 UTC
REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 7 Vijay Bellur 2016-05-23 11:50:39 UTC
REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#3) for review on master by Niels de Vos (ndevos)

Comment 8 Vijay Bellur 2016-05-23 15:12:57 UTC
REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#4) for review on master by Niels de Vos (ndevos)

Comment 9 Vijay Bellur 2016-05-24 10:54:41 UTC
COMMIT: http://review.gluster.org/14503 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit bfd43dc894fcf2cc64ec73e8ea0a779064c47dd4
Author: Niels de Vos <ndevos>
Date:   Mon May 23 11:06:38 2016 +0200

    build: include a dummy config.sub and config.guess in releases
    
    There is no hard requirement for a config.guess and config.sub script in
    the release tarball. By passing --build=... and --host=... to
    ./configure, the scripts are not executed.  When doing local builds, the
    ./autogen.sh script (by running automake) will place a config.guess and
    config.sub script in the root of the source tree. Upon creation of the
    release ('make dist') tarball, the scripts are replaced by dummy copies
    from the build-aux/ directory.
    
    The main advantage to not include these scripts in the repository, is
    that there is no need to track upstream updates for them either.
    
    Change-Id: I5e930988a9e849ec5d0c84d2e30e61f2a9685f45
    BUG: 1223937
    Reported-by: Emmanuel Dreyfus <manu>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/14503
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 10 Niels de Vos 2016-06-16 12:31:57 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user