Bug 1339192 - Missing autotools helper config.* files
Summary: Missing autotools helper config.* files
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: 3.8.0
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On: 1223937
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-24 11:13 UTC by Niels de Vos
Modified: 2016-06-16 14:07 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of: 1223937
Environment:
Last Closed: 2016-06-16 14:07:54 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2016-05-24 11:13:03 UTC
+++ This bug was initially created as a clone of Bug #1223937 +++

Hi,

your config.{guess,sub} files are from 2009-11-20 and outdated, which also means that support for newer ports is missing.
I have attached more up to date versions.

--- Additional comment from Patrick Matthäi on 2015-05-21 20:26:56 CEST ---



--- Additional comment from Kaleb KEITHLEY on 2015-05-29 19:46:34 CEST ---

Our sources don't actually have config.guess and config.sub.

Our jenkins release task clones the source, runs ./autogen.sh (where config.{guess,sub} come from) and ./configure, before running `make dist` to product the release glusterfs-X.Y.Z.tar.gz.

The config.{guess,sub} in the tar file come from the archaic autoconf in CentOS 6.3, which is what the glusterfs jenkins is running on. We are working on updating both jenkins and the platform it runs on.

Even so, we should not be shipping the (arbitrary, old) config.{guess,sub} files from our jenkins machine.

--- Additional comment from Anand Avati on 2015-05-29 19:49:47 CEST ---

REVIEW: http://review.gluster.org/11009 (build: outdated autotools helper config.* files in dist tarfile) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Anand Avati on 2015-05-30 11:41:09 CEST ---

REVIEW: http://review.gluster.org/11009 (build: outdated autotools helper config.* files in dist tarfile) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Vijay Bellur on 2016-05-23 12:35:58 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#1) for review on master by Niels de Vos (ndevos)

--- Additional comment from Vijay Bellur on 2016-05-23 13:47:33 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#2) for review on master by Niels de Vos (ndevos)

--- Additional comment from Vijay Bellur on 2016-05-23 13:50:39 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#3) for review on master by Niels de Vos (ndevos)

--- Additional comment from Vijay Bellur on 2016-05-23 17:12:57 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and config.guess in releases) posted (#4) for review on master by Niels de Vos (ndevos)

--- Additional comment from Vijay Bellur on 2016-05-24 12:54:41 CEST ---

COMMIT: http://review.gluster.org/14503 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit bfd43dc894fcf2cc64ec73e8ea0a779064c47dd4
Author: Niels de Vos <ndevos>
Date:   Mon May 23 11:06:38 2016 +0200

    build: include a dummy config.sub and config.guess in releases
    
    There is no hard requirement for a config.guess and config.sub script in
    the release tarball. By passing --build=... and --host=... to
    ./configure, the scripts are not executed.  When doing local builds, the
    ./autogen.sh script (by running automake) will place a config.guess and
    config.sub script in the root of the source tree. Upon creation of the
    release ('make dist') tarball, the scripts are replaced by dummy copies
    from the build-aux/ directory.
    
    The main advantage to not include these scripts in the repository, is
    that there is no need to track upstream updates for them either.
    
    Change-Id: I5e930988a9e849ec5d0c84d2e30e61f2a9685f45
    BUG: 1223937
    Reported-by: Emmanuel Dreyfus <manu>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/14503
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 1 Vijay Bellur 2016-05-24 11:14:36 UTC
REVIEW: http://review.gluster.org/14517 (build: include a dummy config.sub and config.guess in releases) posted (#1) for review on release-3.8 by Niels de Vos (ndevos)

Comment 2 Vijay Bellur 2016-05-24 14:10:55 UTC
COMMIT: http://review.gluster.org/14517 committed in release-3.8 by Kaleb KEITHLEY (kkeithle) 
------
commit b00eb38bff09b3fec6a273b7cb84cee3fa581a0d
Author: Niels de Vos <ndevos>
Date:   Mon May 23 11:06:38 2016 +0200

    build: include a dummy config.sub and config.guess in releases
    
    There is no hard requirement for a config.guess and config.sub script in
    the release tarball. By passing --build=... and --host=... to
    ./configure, the scripts are not executed.  When doing local builds, the
    ./autogen.sh script (by running automake) will place a config.guess and
    config.sub script in the root of the source tree. Upon creation of the
    release ('make dist') tarball, the scripts are replaced by dummy copies
    from the build-aux/ directory.
    
    The main advantage to not include these scripts in the repository, is
    that there is no need to track upstream updates for them either.
    
    Cherry picked from commit bfd43dc894fcf2cc64ec73e8ea0a779064c47dd4:
    > Change-Id: I5e930988a9e849ec5d0c84d2e30e61f2a9685f45
    > BUG: 1223937
    > Reported-by: Emmanuel Dreyfus <manu>
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/14503
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    
    Change-Id: I5e930988a9e849ec5d0c84d2e30e61f2a9685f45
    BUG: 1339192
    Reported-by: Emmanuel Dreyfus <manu>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/14517
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2016-06-16 14:07:54 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.