Bug 1224187
| Summary: | binutils FTBFS during stage1 bootstrap - logical not is only applied to the left hand side of comparison | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaromír Cápík <jcapik> | ||||||
| Component: | binutils | Assignee: | Nick Clifton <nickc> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 21 | CC: | jakub, mpolacek, nickc, ovasik | ||||||
| Target Milestone: | --- | Keywords: | EasyFix, Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-06-11 15:17:33 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1224209 | ||||||||
| Attachments: |
|
||||||||
Created attachment 1028680 [details]
binutils-2.24-i386-logical-not.patch
I think you want a different patch, I think you'll want to backport https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=ac4eb736520174305bf6e691827f7473b858cff1;hp=ae6c7e33e1510665e8e043eb11a71e59414efbf3 Ahoj Marku. I only fixed the FTBFS. The patch from Alan Modra is a superset of my fix and should do the same job. However the Alan's code looks cleaner, so ... I'm ok with backport :] Hi Guys, I have added Alan's patch to the F21 sources (binutils-2.24-32.fc21.src.rpm). The patch is not needed for F22 or later as the change is already in the binutils tarball. Cheers Nick Hello Nick. Would you mind building it + pushing to testing? You don't need to push it to stable. Our builders pull stuff from updates-testing. Thanks, Jaromir. Hi Jaromir, Done... :-) Cheers Nick Hi Nick. I believe we can close this one. Thanks, Jaromir. |
Created attachment 1028679 [details] binutils.log Description of problem: During stage1 bootstrap we experience FTBFS caused by unsupported evaluation. ---- gcc -DHAVE_CONFIG_H -I. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas -I. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas -I../bfd -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/../include -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/.. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/../bfd -DLOCALEDIR="\"/home/fedora-bootstrap/install/share/locale\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT atof-ieee.o -MD -MP -MF .deps/atof-ieee.Tpo -c -o atof-ieee.o `test -f 'config/atof-ieee.c' || echo '/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/'`config/atof-ieee.c /home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config/tc-i386.c: In function 'build_modrm_byte': /home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config/tc-i386.c:6143:31: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses] && !op.bitfield.reg64 != 1 ^ ---- Tha attached patch fixes that. Version-Release number of selected component (if applicable): binutils-2.24-30.fc21 How reproducible: always