Red Hat Bugzilla – Bug 1224187
binutils FTBFS during stage1 bootstrap - logical not is only applied to the left hand side of comparison
Last modified: 2016-01-31 21:01:30 EST
Created attachment 1028679 [details]
Description of problem:
During stage1 bootstrap we experience FTBFS caused by unsupported evaluation.
gcc -DHAVE_CONFIG_H -I. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas -I. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas -I../bfd -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/../include -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/.. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/../bfd -DLOCALEDIR="\"/home/fedora-bootstrap/install/share/locale\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT atof-ieee.o -MD -MP -MF .deps/atof-ieee.Tpo -c -o atof-ieee.o `test -f 'config/atof-ieee.c' || echo '/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/'`config/atof-ieee.c
/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config/tc-i386.c: In function 'build_modrm_byte':
/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config/tc-i386.c:6143:31: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
&& !op.bitfield.reg64 != 1
Tha attached patch fixes that.
Version-Release number of selected component (if applicable):
Created attachment 1028680 [details]
I think you want a different patch, I think you'll want to backport
I only fixed the FTBFS. The patch from Alan Modra is a superset of my fix and should do the same job. However the Alan's code looks cleaner, so ... I'm ok with backport :]
I have added Alan's patch to the F21 sources (binutils-2.24-32.fc21.src.rpm). The patch is not needed for F22 or later as the change is already in the binutils tarball.
Would you mind building it + pushing to testing? You don't need to push it to stable. Our builders pull stuff from updates-testing.
Hi Nick. I believe we can close this one. Thanks, Jaromir.