Bug 1224428

Summary: Apply button enabled after a failed attempt to upload invalid file for importing tags
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: UI - OPSAssignee: Brian McLaughlin <bmclaugh>
Status: CLOSED CURRENTRELEASE QA Contact: Nandini Chandra <nachandr>
Severity: low Docs Contact:
Priority: medium    
Version: 5.4.0CC: cpelland, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: tag:import
Fixed In Version: 5.7.0.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1348221 (view as bug list) Environment:
Last Closed: 2017-01-11 20:02:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1348221    
Attachments:
Description Flags
screen shot of import tags none

Description Nandini Chandra 2015-05-22 22:57:37 UTC
Created attachment 1028950 [details]
screen shot of import tags

Description of problem:
----------------------


Version-Release number of selected component (if applicable):
------------------------
5.4.0.2


How reproducible:
----------------
Always


Steps to Reproduce:
------------------
1.Navigate to Configure->Configuration.
2.From the 'Import Tags' tab,select an invalid file and hit upload


Actual results:
--------------
Apply button is enabled after a failed attempt to upload an invalid file.


Expected results:
-----------------
Apply button should be greyed out after a failed attempt to upload an invalid file.


Additional info:
----------------
This issue is not seen in 5.3.

Comment 2 Harpreet Kataria 2016-03-23 17:19:15 UTC
Brian,

Apply button should remain disabled if the upload file is invalid. Let me know if you have questions.

~Harpreet

Comment 4 CFME Bot 2016-06-17 15:10:57 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/5510547e23834788eb1115d7315d9df24d12c613

commit 5510547e23834788eb1115d7315d9df24d12c613
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Thu Jun 16 15:33:36 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Fri Jun 17 09:30:16 2016 -0400

    Corrects Apply button states on Import/Import Tags forms
    
    Apply button now remains disabled until valid files are uploaded in the form.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1224428

 app/controllers/ops_controller.rb       |  6 +++---
 spec/controllers/ops_controller_spec.rb | 35 +++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 3 deletions(-)

Comment 5 CFME Bot 2016-06-17 15:11:01 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a143c1b948f815b7ceae2ede676562906d59ef37

commit a143c1b948f815b7ceae2ede676562906d59ef37
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Fri Jun 17 09:25:18 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Fri Jun 17 09:30:16 2016 -0400

    Refactoring to set session[:changed]
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1224428

 app/controllers/ops_controller.rb | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comment 6 CFME Bot 2016-06-17 15:11:05 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/0796dff2cd48eba86ffbb4d05a0ae55ebad59d6f

commit 0796dff2cd48eba86ffbb4d05a0ae55ebad59d6f
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Thu Jun 16 16:54:24 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Fri Jun 17 09:30:16 2016 -0400

    Fix style errors
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1224428

 spec/controllers/ops_controller_spec.rb | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comment 9 Nandini Chandra 2016-10-06 16:51:48 UTC
Verified in 5.7.0.3