Created attachment 1028950 [details] screen shot of import tags Description of problem: ---------------------- Version-Release number of selected component (if applicable): ------------------------ 5.4.0.2 How reproducible: ---------------- Always Steps to Reproduce: ------------------ 1.Navigate to Configure->Configuration. 2.From the 'Import Tags' tab,select an invalid file and hit upload Actual results: -------------- Apply button is enabled after a failed attempt to upload an invalid file. Expected results: ----------------- Apply button should be greyed out after a failed attempt to upload an invalid file. Additional info: ---------------- This issue is not seen in 5.3.
Brian, Apply button should remain disabled if the upload file is invalid. Let me know if you have questions. ~Harpreet
https://github.com/ManageIQ/manageiq/pull/9261
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/5510547e23834788eb1115d7315d9df24d12c613 commit 5510547e23834788eb1115d7315d9df24d12c613 Author: Brian McLaughlin <bmclaugh> AuthorDate: Thu Jun 16 15:33:36 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Fri Jun 17 09:30:16 2016 -0400 Corrects Apply button states on Import/Import Tags forms Apply button now remains disabled until valid files are uploaded in the form. https://bugzilla.redhat.com/show_bug.cgi?id=1224428 app/controllers/ops_controller.rb | 6 +++--- spec/controllers/ops_controller_spec.rb | 35 +++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 3 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/a143c1b948f815b7ceae2ede676562906d59ef37 commit a143c1b948f815b7ceae2ede676562906d59ef37 Author: Brian McLaughlin <bmclaugh> AuthorDate: Fri Jun 17 09:25:18 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Fri Jun 17 09:30:16 2016 -0400 Refactoring to set session[:changed] https://bugzilla.redhat.com/show_bug.cgi?id=1224428 app/controllers/ops_controller.rb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/0796dff2cd48eba86ffbb4d05a0ae55ebad59d6f commit 0796dff2cd48eba86ffbb4d05a0ae55ebad59d6f Author: Brian McLaughlin <bmclaugh> AuthorDate: Thu Jun 16 16:54:24 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Fri Jun 17 09:30:16 2016 -0400 Fix style errors https://bugzilla.redhat.com/show_bug.cgi?id=1224428 spec/controllers/ops_controller_spec.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
https://github.com/ManageIQ/manageiq/pull/7620
Verified in 5.7.0.3