Bug 1225018

Summary:	Scripts/Binaries are not installed with +x bit
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	build	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, kkeithle
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1223945	Environment:
Last Closed:	2016-06-16 13:04:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1223945, 1248498

Description Niels de Vos 2015-05-26 12:18:31 UTC

+++ This bug was initially created as a clone of Bug #1223945 +++

Hi,

the following files are installed by glusterfs without +x:

$libdir/ganesha/ganesha-ha.sh

--- Additional comment from Patrick Matthäi on 2015-05-21 21:05:27 CEST ---

Whops I forget to list some more files:

usr/share/glusterfs/scripts/generate-gfid-file.sh
usr/share/glusterfs/scripts/get-gfid.sh
usr/share/glusterfs/scripts/gsync-upgrade.sh
usr/share/glusterfs/scripts/post-upgrade-script-for-quota.sh
usr/share/glusterfs/scripts/pre-upgrade-script-for-quota.sh
usr/share/glusterfs/scripts/slave-upgrade.sh

--- Additional comment from Niels de Vos on 2015-05-26 14:17:53 CEST ---

The Makefile.am that is located in the directory of the scripts should not list the scripts as _DATA, but as a _SCRIPTS variable. Automake should then set the permissions correctly.

Comment 1 Kaleb KEITHLEY 2015-07-30 12:19:55 UTC

*** Bug 1248498 has been marked as a duplicate of this bug. ***

Comment 2 Anand Avati 2015-07-30 12:39:21 UTC

REVIEW: http://review.gluster.org/11806 (build: scripts are not installed with +x bit) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Anand Avati 2015-07-31 10:14:03 UTC

REVIEW: http://review.gluster.org/11806 (build: scripts are not installed with +x bit) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 4 Anand Avati 2015-07-31 14:13:22 UTC

COMMIT: http://review.gluster.org/11806 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 34517651a6c4507e389ffdb9ac83709bb3346a34
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Jul 30 08:23:37 2015 -0400

    build: scripts are not installed with +x bit
    
    scripts listed in Makefile.am as foo_DATA, should be foo_SCRIPTS
    to be installed +x
    
    Change-Id: Ib9b98efcea968c03b574726bdc0d4f76cdfd1dc1
    BUG: 1225018
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/11806
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 5 Niels de Vos 2016-06-16 13:04:41 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user