Bug 1223945 - Scripts/Binaries are not installed with +x bit
Summary: Scripts/Binaries are not installed with +x bit
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: 3.7.0
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On: 1225018
Blocks: 1248498 glusterfs-3.7.4
TreeView+ depends on / blocked
 
Reported: 2015-05-21 18:36 UTC by Patrick Matthäi
Modified: 2015-09-09 09:37 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.7.4
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1225018 1248498 (view as bug list)
Environment:
Last Closed: 2015-09-09 09:37:57 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Patrick Matthäi 2015-05-21 18:36:10 UTC
Hi,

the following files are installed by glusterfs without +x:

$libdir/ganesha/ganesha-ha.sh

Comment 1 Patrick Matthäi 2015-05-21 19:05:27 UTC
Whops I forget to list some more files:

usr/share/glusterfs/scripts/generate-gfid-file.sh
usr/share/glusterfs/scripts/get-gfid.sh
usr/share/glusterfs/scripts/gsync-upgrade.sh
usr/share/glusterfs/scripts/post-upgrade-script-for-quota.sh
usr/share/glusterfs/scripts/pre-upgrade-script-for-quota.sh
usr/share/glusterfs/scripts/slave-upgrade.sh

Comment 2 Niels de Vos 2015-05-26 12:17:53 UTC
The Makefile.am that is located in the directory of the scripts should not list the scripts as _DATA, but as a _SCRIPTS variable. Automake should then set the permissions correctly.

Comment 3 Anand Avati 2015-07-30 20:10:20 UTC
COMMIT: http://review.gluster.org/11807 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 8b7876c2ef2c969c421f9a001c3506e54e6e4aa0
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Jul 30 08:44:21 2015 -0400

    build: scripts are not installed with +x bit
    
    scripts listed in Makefile.am as foo_DATA, should be foo_SCRIPTS
    to in installed +x
    
    backport of
    > Change-Id: Ib9b98efcea968c03b574726bdc0d4f76cdfd1dc1
    > BUG: 1225018
    > http://review.gluster.org/#/c/11806/
    
    Change-Id: Ieed45f37a22a0ebd977a0d586874a31901c415e9
    BUG: 1223945
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/11807
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Kaushal 2015-09-09 09:37:57 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.