Bug 1225406

Summary:	Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem
Product:	[Fedora] Fedora	Reporter:	Michal Srb <msrb>
Component:	Package Review	Assignee:	Josef Stribny <jstribny>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hhorak, package-review, vondruch
Target Milestone:	---	Flags:	jstribny: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-01-04 09:07:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1198676

Description Michal Srb 2015-05-27 10:17:17 UTC

Spec URL: https://msrb.fedorapeople.org/rubygem-jruby-openssl.spec
SRPM URL: https://msrb.fedorapeople.org/rubygem-jruby-openssl-0.9.7-1.fc23.src.rpm
Description: JRuby-OpenSSL is an add-on gem for JRuby that emulates the Ruby OpenSSL native library. Under the hood uses the Bouncy Castle Crypto APIs.
Fedora Account System Username: msrb

Comment 1 Josef Stribny 2015-05-27 10:41:42 UTC

I will take it for a review.

Comment 2 Josef Stribny 2015-05-27 12:30:57 UTC

* This package is intended for JRuby only and fails on CRuby, so proper Requires: jruby should be used.

# irb
irb(main):001:0> require 'jopenssl/load'
Loading jruby-openssl in a non-JRuby interpreter
LoadError: cannot load such file -- java
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /usr/share/gems/gems/jruby-openssl-0.9.7/lib/jopenssl/load.rb:3:in `<top (required)>'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `rescue in require'
	from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:39:in `require'
	from (irb):1
	from /usr/bin/irb:11:in `<main>'


* Requires: ruby(release) is auto-generated and should be deleted.

* I would appreciate a comment above the following like specifying the referenced library:

%global bc_version 1.50

Comment 3 Michal Srb 2015-05-27 12:49:50 UTC

Updated spec+srpm:

Spec URL: https://msrb.fedorapeople.org/2/rubygem-jruby-openssl.spec
SRPM URL: https://msrb.fedorapeople.org/2/rubygem-jruby-openssl-0.9.7-2.fc23.src.rpm


%changelog
* Wed May 27 2015 Michal Srb <msrb> - 0.9.7-2
- Explicitly require JRuby
- Drop R: ruby(release)
- Add comment for %%bc_version

Comment 4 Josef Stribny 2015-06-09 06:51:24 UTC

For the question of packaging the Java extensions I opened an upstream issue:
https://github.com/rubygems/rubygems/issues/1260

Comment 5 Josef Stribny 2015-06-30 10:43:05 UTC

I don't believe we can do much about the way Java extensions are packaged in upstream .gem packages at the moment, therefore I no longer see this as a blocker for the review. Let's make JRuby functional, we can deal with this later if necessary.

==> APPROVED.

Comment 6 Michal Srb 2015-07-03 12:04:16 UTC

Thanks for the review!

New Package SCM Request
=======================
Package Name: rubygem-jruby-openssl
Short Description: JRuby's OpenSSL gem
Upstream URL: https://github.com/jruby/jruby-openssl
Owners: msrb mizdebsk msimacek
Branches: f22
InitialCC: java-sig

Comment 7 Gwyn Ciesla 2015-07-05 04:00:42 UTC

Git done (by process-git-requests).

Comment 9 Vít Ondruch 2016-01-04 09:07:01 UTC

Closing this ticket, since the package is in Fedora for some time already.