Spec URL: https://msrb.fedorapeople.org/rubygem-jruby-openssl.spec SRPM URL: https://msrb.fedorapeople.org/rubygem-jruby-openssl-0.9.7-1.fc23.src.rpm Description: JRuby-OpenSSL is an add-on gem for JRuby that emulates the Ruby OpenSSL native library. Under the hood uses the Bouncy Castle Crypto APIs. Fedora Account System Username: msrb
I will take it for a review.
* This package is intended for JRuby only and fails on CRuby, so proper Requires: jruby should be used. # irb irb(main):001:0> require 'jopenssl/load' Loading jruby-openssl in a non-JRuby interpreter LoadError: cannot load such file -- java from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' from /usr/share/gems/gems/jruby-openssl-0.9.7/lib/jopenssl/load.rb:3:in `<top (required)>' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `rescue in require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:39:in `require' from (irb):1 from /usr/bin/irb:11:in `<main>' * Requires: ruby(release) is auto-generated and should be deleted. * I would appreciate a comment above the following like specifying the referenced library: %global bc_version 1.50
Updated spec+srpm: Spec URL: https://msrb.fedorapeople.org/2/rubygem-jruby-openssl.spec SRPM URL: https://msrb.fedorapeople.org/2/rubygem-jruby-openssl-0.9.7-2.fc23.src.rpm %changelog * Wed May 27 2015 Michal Srb <msrb> - 0.9.7-2 - Explicitly require JRuby - Drop R: ruby(release) - Add comment for %%bc_version
For the question of packaging the Java extensions I opened an upstream issue: https://github.com/rubygems/rubygems/issues/1260
I don't believe we can do much about the way Java extensions are packaged in upstream .gem packages at the moment, therefore I no longer see this as a blocker for the review. Let's make JRuby functional, we can deal with this later if necessary. ==> APPROVED.
Thanks for the review! New Package SCM Request ======================= Package Name: rubygem-jruby-openssl Short Description: JRuby's OpenSSL gem Upstream URL: https://github.com/jruby/jruby-openssl Owners: msrb mizdebsk msimacek Branches: f22 InitialCC: java-sig
Git done (by process-git-requests).
Closing this ticket, since the package is in Fedora for some time already.