Bug 1225491

Summary:	[AFR-V2] - afr_final_errno() should treat op_ret > 0 also as success
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	replicate	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1225743 1225745 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:05:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1225743, 1225745, 1226163

Description Krutika Dhananjay 2015-05-27 13:31:37 UTC

Description of problem:

Figured while reading code that the function afr_final_errno() does not treat op_ret > 0 as success.

What that means is that in inode write fops (where this function gets called by __afr_inode_write_finalize()), op_ret could be > 0 on success. And if the inode write fop failed on one or more subvols, there is a remote possibility that AFR, instead of choosing the most severe errno from the set of errnos returned by the subvolumes that saw a failure, winds up picking junk errno from the subvol where the fop actually succeeded. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-05-27 13:35:46 UTC

REVIEW: http://review.gluster.org/10946 (cluster/afr: Treat op_ret >= 0 as success in afr_final_errno()) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-05-28 05:36:28 UTC

COMMIT: http://review.gluster.org/10946 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 9e1bb640983f72858aeabd793bbb7fc8b5c71b09
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 27 19:03:12 2015 +0530

    cluster/afr: Treat op_ret >= 0 as success in afr_final_errno()
    
    Change-Id: I7ec29428b7f7ef249014f948a5d616bfb8aaf80d
    BUG: 1225491
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10946
    Tested-by: NetBSD Build System
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Nagaprasad Sathyanarayana 2015-10-25 14:51:29 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 4 Niels de Vos 2016-06-16 13:05:25 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user