+++ This bug was initially created as a clone of Bug #1225491 +++ Description of problem: Figured while reading code that the function afr_final_errno() does not treat op_ret > 0 as success. What that means is that in inode write fops (where this function gets called by __afr_inode_write_finalize()), op_ret could be > 0 on success. And if the inode write fop failed on one or more subvols, there is a remote possibility that AFR, instead of choosing the most severe errno from the set of errnos returned by the subvolumes that saw a failure, winds up picking junk errno from the subvol where the fop actually succeeded. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Anand Avati on 2015-05-27 09:35:46 EDT --- REVIEW: http://review.gluster.org/10946 (cluster/afr: Treat op_ret >= 0 as success in afr_final_errno()) posted (#1) for review on master by Krutika Dhananjay (kdhananj) --- Additional comment from Anand Avati on 2015-05-28 01:36:28 EDT --- COMMIT: http://review.gluster.org/10946 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit 9e1bb640983f72858aeabd793bbb7fc8b5c71b09 Author: Krutika Dhananjay <kdhananj> Date: Wed May 27 19:03:12 2015 +0530 cluster/afr: Treat op_ret >= 0 as success in afr_final_errno() Change-Id: I7ec29428b7f7ef249014f948a5d616bfb8aaf80d BUG: 1225491 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/10946 Tested-by: NetBSD Build System Reviewed-by: Ravishankar N <ravishankar> Reviewed-by: Pranith Kumar Karampuri <pkarampu>
REVIEW: http://review.gluster.org/10961 (cluster/afr: Treat op_ret >= 0 as success in afr_final_errno()) posted (#2) for review on release-3.6 by Krutika Dhananjay (kdhananj)
COMMIT: http://review.gluster.org/10961 committed in release-3.6 by Raghavendra Bhat (raghavendra) ------ commit bc37696f76ee7575ab7321e3ee1ebaaefe759caa Author: Krutika Dhananjay <kdhananj> Date: Wed May 27 19:03:12 2015 +0530 cluster/afr: Treat op_ret >= 0 as success in afr_final_errno() Backport of: http://review.gluster.org/10946 Change-Id: I6ca36fee5dc46f2a2afe04f3359c4102f45c3ae0 BUG: 1225745 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/10961 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Ravishankar N <ravishankar> Reviewed-by: Raghavendra Bhat <raghavendra>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v3.6.4, please open a new bug report. glusterfs-v3.6.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2015-July/022826.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user