Bug 1225713
Summary: | Can not add XFCE4 Places plugin to panel | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Shivaji Sathe <shivaji_p_sathe> | ||||
Component: | xfce4-places-plugin | Assignee: | Christoph Wickert <christoph.wickert> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 22 | CC: | christoph.wickert, fry.kun, johannes.lips, kevin, nonamedotc, theo148 | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | xfce4-places-plugin-1.7.0-3.fc22 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-07-02 17:08:03 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Shivaji Sathe
2015-05-28 04:49:38 UTC
Filed upstream: https://bugzilla.xfce.org/show_bug.cgi?id=11939 I can't see why you marked this bug private... was there some reason? Thanks for filing upstream, I hope it's valid issue and helps :) I have used Fedora for fairly long time. However, apart from couple of ABRT reports, this is first time I have manually filed Fedora issue. There is no other reason than keeping the email private as much as possible. I thought issue would be still searchable who have bugzilla account. It's not letting me unmark the private status now. I will keep in mind next time. hitting the same bug after fedup I think, there's an easy fix in the upstream bugzilla. Basically it's because of gcc5. I played around with it some last week and was unable to get that fix to work... Created attachment 1041339 [details]
Proposed patch which worked locally for me
I got a chance to work with the sources myself. From what I understood I replaced "inline" with "extern inline" in model.h. I think it shouldn't break gnu89 compatibility either. I built the package locally and worked for me.
Is it possible to review and integrate the patch at least for Fedora?
I can confirm the fix, please find a scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=10172853 I installed koji package and have started using Places plugin now. So does that mean this will be part of fedora update eventually? xfce4-places-plugin-1.7.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/xfce4-places-plugin-1.7.0-3.fc22 Thanks much for the patch! Would you like to attach it to the upstream bug as well? Sure, you may attach the patch there for XFCE devs to consider. Sure, done. Thanks again. Thanks. Glad I could help. Package xfce4-places-plugin-1.7.0-3.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing xfce4-places-plugin-1.7.0-3.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-10530/xfce4-places-plugin-1.7.0-3.fc22 then log in and leave karma (feedback). xfce4-places-plugin-1.7.0-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |