Bug 1225842
| Summary: | Minor improvements and cleanup for the build system | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Humble Chirammal <hchiramm> |
| Component: | build | Assignee: | bugs <bugs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 3.7.0 | CC: | amukherj, bugs, kkeithle, ndevos |
| Target Milestone: | --- | Keywords: | Tracking, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1198849 | Environment: | |
| Last Closed: | 2016-10-17 09:04:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1198849, 1290534 | ||
| Bug Blocks: | |||
|
Description
Humble Chirammal
2015-05-28 10:19:38 UTC
REVIEW: http://review.gluster.org/10964 (spec: correct the vendor string in spec file) posted (#2) for review on release-3.7 by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/14128 (rpc: fix gf_process_reserved_ports) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever (pkalever) REVIEW: http://review.gluster.org/14128 (rpc: fix gf_process_reserved_ports) posted (#2) for review on release-3.7 by Prasanna Kumar Kalever (pkalever) REVIEW: http://review.gluster.org/15401 (build: correctly format some (s)size_t messages) posted (#1) for review on release-3.7 by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/15401 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) ------ commit 4f030852e3a4da367a948158cc8cf152e62bcee5 Author: Niels de Vos <ndevos> Date: Mon Sep 5 16:53:38 2016 +0200 build: correctly format some (s)size_t messages On 32-bit builds the are are warnings like these: posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t' Instead of using "%l" for (signed) size_t variables, "%z" should be used. Cherry picked from commit 3af889f02722f4636d2ea30570de6477e8b5a3a9: > BUG: 1198849 > Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf > Signed-off-by: Niels de Vos <ndevos> > Reviewed-on: http://review.gluster.org/14933 > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Kaleb KEITHLEY <kkeithle> > Smoke: Gluster Build System <jenkins.org> This patch is not really recommended for backporting, but we do have a new smoke test that fails when these warnings pop-up. It is cleaner to correct the code in the release-3.7 branch then to modify the smoke test to skip this branch. Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf BUG: 1225842 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/15401 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> Smoke: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.16, please open a new bug report. glusterfs-3.7.16 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-devel/2016-October/051187.html [2] https://www.gluster.org/pipermail/gluster-users/ |