Use this bug to file changes that affect the build tools and configuration. Real bugs (problem reports) should have their own bugzilla entry for related patches. Acceptable changes include: - improve readability - minor checkpatch.pl changes - cleanup in Makefile.am files or configure.ac - ...
REVIEW: http://review.gluster.org/9784 (build: adjust checkpatch for HEAD) posted (#2) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/9803 (build: add more generated files to .gitignore) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/9784 (build: adjust checkpatch for HEAD.) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)
COMMIT: http://review.gluster.org/9784 committed in master by Niels de Vos (ndevos) ------ commit 0bef7717d3100734c6c5a4ba85de7a39e76774db Author: Michael Scherer <misc> Date: Mon Mar 2 16:24:05 2015 +0100 build: adjust checkpatch for HEAD. README is called README.md in git HEAD, and we have a directory heal. Change-Id: I2e698b95c6924b5b21aa54257fefd6a6698255ee BUG: 1198849 Signed-off-by: Michael Scherer <misc> Reviewed-on: http://review.gluster.org/9784 Reviewed-by: Humble Devassy Chirammal <humble.devassy> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos>
COMMIT: http://review.gluster.org/9803 committed in master by Niels de Vos (ndevos) ------ commit 4f2b49eefd1a56469770534d7941fa37ae759f11 Author: Niels de Vos <ndevos> Date: Wed Mar 4 16:22:39 2015 +0100 build: add more generated files to .gitignore Added *_unittest, *.log, *.trs, extras/run-gluster.tmpfiles and heal/src/glfsheal. Sorted the list of files to make it easier to modify in future. Change-Id: I0f21a03a89e61f84c6a85c8f1f98712c5819d633 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/9803 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: http://review.gluster.org/9928 (marker: fix compile time warning on buf arg.) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)
COMMIT: http://review.gluster.org/9928 committed in master by Niels de Vos (ndevos) ------ commit dbd62a8d2b50392fbed0a0781a4f241dadb8f506 Author: Humble Devassy Chirammal <hchiramm> Date: Wed Mar 18 15:25:08 2015 +0530 marker: fix compile time warning on buf arg. Problem: marker-quota.c: In function 'mq_inspect_directory_xattr_task': marker-quota.c:3451:31: warning: variable 'buf' set but not used [-Wunused-but-set-variable] struct iatt buf = {0,}; Change-Id: I211378328bdb2509a5d2a186d173f7f30a670c8a BUG: 1198849 Signed-off-by: Humble Devassy Chirammal <hchiramm> Reviewed-on: http://review.gluster.org/9928 Reviewed-by: Vijaikumar Mallikarjuna <vmallika> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/9940 (build: let checkpatch check for a trailing dot) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/9958 (glupy: correct the definition of GlusterFS in setup.py) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9963 (build: only include sys/sysctl.h when sysctl() is used) posted (#1) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/9963 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 889044594614756243259a22ed1448408a2b33ac Author: Niels de Vos <ndevos> Date: Sun Mar 22 13:17:46 2015 +0100 build: only include sys/sysctl.h when sysctl() is used BUG: 1198849 Change-Id: I9597b4b7f37994865f88b99651ea9ec89787f5cf Reported-by: Adam Borowski <kilobyte> URL: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778790 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/9963 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle>
COMMIT: http://review.gluster.org/9940 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 2308c07b9d52b28f371388b9393b17508b2ddccd Author: Niels de Vos <ndevos> Date: Thu Mar 19 10:38:23 2015 +0100 build: let checkpatch check for a trailing dot The subject of a patch should not end with a dot (.). It is not common to have subjects of emails end with a dot, and neither is it common for patches. Change-Id: Id090241393aee3ca99df4887bdb2d7a7a8913164 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/9940 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Ira Cooper <ira> Reviewed-by: Lalatendu Mohanty <lmohanty> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: http://review.gluster.org/9958 (glupy: correct the definition of GlusterFS in setup.py) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/9997 (features/ctr: Removing rpc-lib, rpc-xdr and api from CPPFLAGS) posted (#1) for review on master by Anoop C S (achiraya)
COMMIT: http://review.gluster.org/9997 committed in master by Niels de Vos (ndevos) ------ commit f64666f113e7f0d3f7061dfed7e6e24928e85161 Author: Anoop C S <achiraya> Date: Wed Mar 25 19:51:41 2015 +0530 features/ctr: Removing rpc-lib, rpc-xdr and api from CPPFLAGS Changetimerecorder doesn't seem to use rpc-lib, rpc-xdr and gfapi in the source. So removing those from Makefile.am Change-Id: I21c71db6212c10ba3821c6c456958a45c5312d41 BUG: 1198849 Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/9997 Reviewed-by: Joseph Fernandes <josferna> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos>
REVIEW: http://review.gluster.org/10040 (build: ignore cscope files) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/10040 (build: ignore cscope files) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/10040 (build: ignore cscope files) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)
COMMIT: http://review.gluster.org/9958 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit d2629aef8302c6b7d832063351c0ce1f2f2efbdd Author: Humble Devassy Chirammal <hchiramm> Date: Sat Mar 21 15:57:13 2015 +0530 glupy: correct the definition of GlusterFS in setup.py Change-Id: I31597a623b4ebf3d3129067eb20c661c910b97fe BUG: 1198849 Signed-off-by: Humble Devassy Chirammal <hchiramm> Reviewed-on: http://review.gluster.org/9958 Reviewed-by: Lalatendu Mohanty <lmohanty> Tested-by: Gluster Build System <jenkins.com>
COMMIT: http://review.gluster.org/10040 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 0a3420dbd57361174eb30fc054754f8c5499ecfb Author: Humble Devassy Chirammal <hchiramm> Date: Mon Mar 30 12:32:27 2015 +0530 build: ignore cscope files It is common for developers to use cscope and generate these cscope.* files with: cscope -b -q or with some other switches of cscope. This patch avoid 'git' to worry about the same. Change-Id: I3525e6f1a36f9800f4c27a2cdc6ea9c668981717 BUG: 1198849 Signed-off-by: Humble Devassy Chirammal <hchiramm> Reviewed-on: http://review.gluster.org/10040 Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/10099 (build: sort gitignore entries) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/10099 (build: sort gitignore entries) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/10099 (build: sort gitignore entries) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/10132 (build: add more files to .gitignore) posted (#1) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/10132 committed in master by Niels de Vos (ndevos) ------ commit dc128c6bb0f8935e0aaa64602cd8a2dcedaebbf4 Author: Niels de Vos <ndevos> Date: Mon Apr 6 15:01:15 2015 +0530 build: add more files to .gitignore Change-Id: Icef0d7f443f7caf3aa386d3a6978f98cf3a5a4af BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/10132 Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Gluster Build System <jenkins.com>
COMMIT: http://review.gluster.org/10099 committed in master by Niels de Vos (ndevos) ------ commit 120cdbf3ba51f493df3bff112a9e21c19349b543 Author: Humble Devassy Chirammal <hchiramm> Date: Mon Mar 30 12:49:13 2015 +0530 build: sort gitignore entries Change-Id: I79d315efb47577ab88d090a96df13f1f92ed276c BUG: 1198849 Signed-off-by: Humble Devassy Chirammal <hchiramm> Reviewed-on: http://review.gluster.org/10099 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos>
REVIEW: http://review.gluster.org/10885 (spec: correct the vendor string in spec file) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/10885 (spec: correct the vendor string in spec file) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)
REVIEW: http://review.gluster.org/10897 (build: do not include rpcgen generated files in "make dist") posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/10897 (build: do not include rpcgen generated files in "make dist") posted (#2) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/10897 (build: do not include rpcgen generated files in "make dist") posted (#3) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/10885 committed in master by Niels de Vos (ndevos) ------ commit bc33fe3c1621612788cf2f7928178f314a5f25f1 Author: Humble Devassy Chirammal <hchiramm> Date: Thu May 21 21:30:54 2015 +0530 spec: correct the vendor string in spec file Change-Id: Id19c973092af506582741887d12fe00c85022f15 BUG: 1198849 Signed-off-by: Humble Devassy Chirammal <hchiramm> Reviewed-on: http://review.gluster.org/10885 Tested-by: NetBSD Build System Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/11020 (rpm: add option "--with debug" for rpmbuild/mock) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/11020 (rpm: add option "--with debug" for rpmbuild/mock) posted (#2) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/11020 (rpm: add option "--with debug" for rpmbuild/mock) posted (#3) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/11020 (rpm: add option "--with debug" for rpmbuild/mock) posted (#4) for review on master by Vijay Bellur (vbellur)
COMMIT: http://review.gluster.org/11020 committed in master by Niels de Vos (ndevos) ------ commit ffe8b4d8149b50df53353bdb85fac1251a85ec2f Author: Niels de Vos <ndevos> Date: Sun May 31 21:50:21 2015 +0200 rpm: add option "--with debug" for rpmbuild/mock When passing "--with debug" to mock or rpmbuild, the build process will add the "--enable-debug" option to ./configure. This makes it easier to build RPMs with debugging enabled. Change-Id: Ie584a4a03525385b337bbf81e5093f2af1b0b780 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/11020 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: http://review.gluster.org/11297 (build: always include the VERSION file in 'make dist') posted (#2) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/11297 committed in master by Niels de Vos (ndevos) ------ commit 5f76ff1beaaf1fd1c85c43a166c289f9094a379b Author: Niels de Vos <ndevos> Date: Wed Jun 17 23:33:25 2015 +0200 build: always include the VERSION file in 'make dist' Building a 'make dist' tarball from a non-git directory fails to include the VERSION file. This subsequently fails to set the version in the installation directories (for the xlators) and the RPM packaging can not find the correct files. This change makes sure to include a VERSION file in the 'make dist' tarball, no matter from where 'make dist' is run. It mainly addresses this use case: $ git clone ... && cd glusterfs $ ./autogen.sh $ mkdir /tmp/workdir $ cd /tmp/workdir $ $OLDPWD/configure $ make dist Change-Id: I3e87b5e16118b68d065fe99790d4b17e0cef9189 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/11297 Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Gluster Build System <jenkins.com> Tested-by: NetBSD Build System <jenkins.org>
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#1) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#2) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#3) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#4) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#5) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#6) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#7) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12351 (build: Fix autoconf warnings) posted (#8) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12714 (build: Remove redundant options from GF_CFLAGS) posted (#1) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/12828 (extras: fix deprecation warining in checkpatch.pl) posted (#1) for review on master by Michael Adam (obnox)
COMMIT: http://review.gluster.org/12714 committed in master by Jeff Darcy (jdarcy) ------ commit 86701a0ececa5fdbbe08654516618baadc4555b7 Author: Anoop C S <anoopcs> Date: Mon Nov 23 12:20:09 2015 +0530 build: Remove redundant options from GF_CFLAGS While configuring, GF_CFLAGS is being populated with redudndant options as follows: Normal mode: GF_CFLAGS = -g -O2 -g -O2 -Wformat -Werror=format-security \ -g -O2 -g -O2 -Wformat -Werror=format-security \ -Werror=implicit-function-declaration Debug mode: GF_CFLAGS = -g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \ -g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \ -Werror=implicit-function-declaration This patch is to remove this redundancy of options. Change-Id: Idf6f2536c2a8ae24ba257681fbe9dfdb8bfa4f19 BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/12714 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Jeff Darcy <jdarcy>
COMMIT: http://review.gluster.org/12828 committed in master by Jeff Darcy (jdarcy) ------ commit 2e9376a2f1b992d3649dd1d5a8e844b4c031ef3c Author: Michael Adam <obnox> Date: Mon Nov 30 13:35:23 2015 +0100 extras: fix deprecation warining in checkpatch.pl Left braces in patterns need to be escaped. Otherwise, for perl >= 5.16, we get a warning: "Unescaped left brace in regex is deprecated, passed through in regex;" This patch fixes the relevant braces. Hence perl -c ./examples/checkpatch.pl is clean again. Change-Id: I938c9c262239f53de57d30a2cff7030f22e63dc1 BUG: 1198849 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/12828 Reviewed-by: Anoop C S <anoopcs> Reviewed-by: Niels de Vos <ndevos> Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/13208 (build: place glupy under $prefix while installing) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/13208 (build: place glupy under $prefix while installing) posted (#2) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/13208 committed in master by Niels de Vos (ndevos) ------ commit a34c406445fc0294de41a8e4706f106a83e136a0 Author: Niels de Vos <ndevos> Date: Sun Jan 10 13:42:58 2016 +0100 build: place glupy under $prefix while installing Regression testing on FreeBSD fails due to this error: --- install-pyglupyPYTHON --- /usr/home/jenkins/root/workspace/freebsd-smoke/install-sh -c -d '/usr/local/lib/python2.7/site-packages/gluster/glupy' mkdir: /usr/local/lib/python2.7/site-packages/gluster: Permission denied mkdir: /usr/local/lib/python2.7/site-packages/gluster: Permission denied *** [install-pyglupyPYTHON] Error code 1 The installation prefix is set to "/build/install" and glupy should be placed there as well. The default to "/usr/local" is incorrect. Change-Id: I166412a271576f2344aecec94c7835f0fe9b1cf3 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/13208 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: http://review.gluster.org/13964 (qemu-block: mop leftover code) posted (#2) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/13997 (rpc: modify gf_process_reserved_ports to return void) posted (#1) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/13997 (rpc: modify gf_process_reserved_ports to return void) posted (#2) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/13964 (qemu-block: mop leftover code) posted (#3) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/13964 (qemu-block: mop leftover code) posted (#4) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/14033 (build: remove unused gf_darwin_compat_*xattr() functions) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/14034 (build: reduce warnings when building the syscall compatibility layer) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/13997 (rpc: modify gf_process_reserved_ports to return void) posted (#4) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/14034 (build: reduce warnings when building the syscall compatibility layer) posted (#2) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/14033 (build: remove unused gf_darwin_compat_*xattr() functions) posted (#2) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/14034 (build: reduce warnings when building the syscall compatibility layer) posted (#3) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/14033 (build: remove unused gf_darwin_compat_*xattr() functions) posted (#3) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/13964 committed in master by Niels de Vos (ndevos) ------ commit bfd5c7683708949e87bd40fb0ddb6933021c6912 Author: Prasanna Kumar Kalever <prasanna.kalever> Date: Mon Apr 11 15:28:07 2016 +0530 qemu-block: mop leftover code This patch cleans off the code that was leftover by '6860968' which basically remove qemu-block from gluster code repo Also update 'bug-1168803-snapd-option-validation-fix.t' which previously used 'features.file-snapshot' for checking 'volume set' for some reason. Change-Id: I2c4f28e186b74a4ce55d48c0fa7f3f79ca1901b5 BUG: 1198849 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever> Reviewed-on: http://review.gluster.org/13964 Tested-by: Prasanna Kumar Kalever <pkalever> Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Niels de Vos <ndevos>
COMMIT: http://review.gluster.org/14033 committed in master by Niels de Vos (ndevos) ------ commit 68034a3f92a779f8fe67525472f450d473769dd3 Author: Niels de Vos <ndevos> Date: Tue Apr 19 17:52:26 2016 +0200 build: remove unused gf_darwin_compat_*xattr() functions These functions are not implemented or used anywhere, there is no reason to have them declared in the compatibility header. Change-Id: If33ed2cc0be86b9f04f05f3af822758e263f6d53 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14033 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle>
COMMIT: http://review.gluster.org/14034 committed in master by Niels de Vos (ndevos) ------ commit 30b66ef3750ece0fb56e673afaca7948d53511e1 Author: Niels de Vos <ndevos> Date: Mon Apr 18 19:24:41 2016 +0200 build: reduce warnings when building the syscall compatibility layer For whatever reason my Fedora 23 started to complain loudly when compiling syscall.c. Change-Id: I72d278d6dc9abb77018c2590c113552383b639d1 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14034 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: http://review.gluster.org/13997 (rpc: fix gf_process_reserved_ports) posted (#5) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/13997 (rpc: fix gf_process_reserved_ports) posted (#6) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/13997 (rpc: fix gf_process_reserved_ports) posted (#7) for review on master by Prasanna Kumar Kalever (pkalever)
REVIEW: http://review.gluster.org/14093 (build: remove unneeded include <sys/user.h> for FreeBSD) posted (#1) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/13997 committed in master by Jeff Darcy (jdarcy) ------ commit 88a386b9c87072787a3b712073cbf19a74b0bd20 Author: Prasanna Kumar Kalever <prasanna.kalever> Date: Tue Apr 26 21:42:23 2016 +0530 rpc: fix gf_process_reserved_ports this patch also does minor code cleanups. Change-Id: I0d005bd0f9baaaae498aa1df4faa6fcb65fa7a6e BUG: 1198849 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever> Reviewed-on: http://review.gluster.org/13997 Tested-by: Prasanna Kumar Kalever <pkalever> Smoke: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Jeff Darcy <jdarcy> NetBSD-regression: NetBSD Build System <jenkins.org>
REVIEW: http://review.gluster.org/14093 (build: remove unneeded include <sys/user.h> for FreeBSD) posted (#2) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/14093 committed in master by Jeff Darcy (jdarcy) ------ commit fbb655d90aae42398c51469919dde20138e89d7d Author: Niels de Vos <ndevos> Date: Wed Apr 27 14:50:58 2016 +0200 build: remove unneeded include <sys/user.h> for FreeBSD The include <sys/user.h> causes a conflicting definition of an RPC 'struct pmap': --- fuse-helpers.lo --- In file included from /usr/include/rpc/rpc.h:73:0, from ../../../../libglusterfs/src/glusterfs-fops.h:35, from /usr/home/jenkins/root/workspace/freebsd-smoke/libglusterfs/src/glusterfs.h:32, from /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-bridge.h:22, from /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-helpers.c:26: /usr/include/rpc/pmap_prot.h:89:8: error: redefinition of 'struct pmap' struct pmap { ^ In file included from /usr/include/vm/pmap.h:90:0, from /usr/include/sys/user.h:52, from /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-helpers.c:19: /usr/include/machine/pmap.h:299:8: note: originally defined here struct pmap { ^ It seems that building on FreeBSD still functions without any additional warnings or errors, even when the include is removed. Change-id I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9 identified this issue, and this build-fix is needed for applying I98fc8cf7. BUG: 1198849 Change-Id: Ib8241b7dc47eb2c3593d2f8ea1d196178e63d02d Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14093 NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Jeff Darcy <jdarcy>
REVIEW: http://review.gluster.org/14933 (build: correctly format some (s)size_t messages) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/14934 (build: fix sprintf format for uint64_t) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/14934 (build: fix sprintf format for uint64_t in gf_worm_serialize_state()) posted (#2) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/14933 committed in master by Jeff Darcy (jdarcy) ------ commit 3af889f02722f4636d2ea30570de6477e8b5a3a9 Author: Niels de Vos <ndevos> Date: Sat Jul 16 14:21:47 2016 +0200 build: correctly format some (s)size_t messages On 32-bit builds the are are warnings like these: posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t' Instead of using "%l" for (signed) size_t variables, "%z" should be used. BUG: 1198849 Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14933 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> Smoke: Gluster Build System <jenkins.org>
COMMIT: http://review.gluster.org/14934 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 1b228d3d489cada1c3c9f5fdbb882e7dbc25a091 Author: Niels de Vos <ndevos> Date: Sat Jul 16 16:36:22 2016 +0200 build: fix sprintf format for uint64_t in gf_worm_serialize_state() When building on 32-bit architectures, the following warning gets reported: worm-helper.c: In function 'gf_worm_serialize_state': worm-helper.c:219: warning: format '%ld' expects type 'long int', but argument 4 has type 'uint64_t' worm-helper.c:219: warning: format '%ld' expects type 'long int', but argument 5 has type 'uint64_t' The format string "%ld" depend on the architecture. If the type is very specific (here unint64_t), the dynamicness of "%ld" is not correct. There are macros for these fixed types in <inttypes.h> and even some more in "logging.h" from libglusterfs. BUG: 1198849 Change-Id: I63eeb9c8e4d7b292ce0c9333938ca365db0823fc Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14934 NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: http://review.gluster.org/15400 (build: move checkpatch.pl to build-aux) posted (#1) for review on master by Niels de Vos (ndevos)
REVIEW: http://review.gluster.org/15423 (libglusterfs: Fix wrong git repository url) posted (#2) for review on master by Anoop C S (anoopcs)
COMMIT: http://review.gluster.org/15423 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 34278a042f834b84c5d12fc3f45259136808466b Author: Anoop C S <anoopcs> Date: Thu Sep 8 10:11:01 2016 +0530 libglusterfs: Fix wrong git repository url Change-Id: Iecd4cfacd7536cb3cc9a569c8d96e5284f5e2152 BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/15423 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: jiffin tony Thottan <jthottan> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle>
COMMIT: http://review.gluster.org/15400 committed in master by Niels de Vos (ndevos) ------ commit 00d9abd401ed5d6d78e9641ea31fe0e677f34eb9 Author: Niels de Vos <ndevos> Date: Mon Sep 5 11:39:10 2016 +0200 build: move checkpatch.pl to build-aux There is no need for checkpatch.pl to be in extras/, it is used similar to other scripts that are placed in build-aux/. Change-Id: Id0f4db1666d83dad31687aa7aadae128fc14c016 BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/15400 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org>
REVIEW: http://review.gluster.org/15666 (build: Avoid printing python version to stdout discovered during configure) posted (#1) for review on master by Anoop C S (anoopcs)
COMMIT: http://review.gluster.org/15666 committed in master by Niels de Vos (ndevos) ------ commit fd045aefbd2ea8315f76e6659753ebd1d7b6d801 Author: Anoop C S <anoopcs> Date: Tue Oct 18 12:19:39 2016 +0530 build: Avoid printing python version to stdout discovered during configure Change-Id: I1e0d0dd462cd8fa6d3ce40850099e8a019d754de BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/15666 Reviewed-by: Niels de Vos <ndevos> Tested-by: Niels de Vos <ndevos> CentOS-regression: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org>
REVIEW: http://review.gluster.org/15819 (Update copyright year for glusterfs binaries) posted (#1) for review on master by Anoop C S (anoopcs)
REVIEW: http://review.gluster.org/15819 (Update copyright content for glusterfs binaries) posted (#2) for review on master by Anoop C S (anoopcs)
COMMIT: http://review.gluster.org/15819 committed in master by Vijay Bellur (vbellur) ------ commit 7947a6dd63979c7638f60d1a0954d9f78fd7df21 Author: Anoop C S <anoopcs> Date: Thu Nov 10 12:34:48 2016 +0530 Update copyright content for glusterfs binaries Change-Id: I2d5de7ae634d55ae32977e337f366586eab449e4 BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/15819 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/15899 (protocol/server: Remove unused variable) posted (#1) for review on master by Anoop C S (anoopcs)
COMMIT: http://review.gluster.org/15899 committed in master by Vijay Bellur (vbellur) ------ commit ded44a2627e5421880ffcc798f2838f52faaf322 Author: Anoop C S <anoopcs> Date: Tue Nov 22 06:34:35 2016 +0000 protocol/server: Remove unused variable Change-Id: I0d0a786b2d02d4db37c4da6194ee4b4feac31b63 BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/15899 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/15985 (build: Use %{_datadir} rpm macro in spec file) posted (#1) for review on master by Anoop C S (anoopcs)
COMMIT: http://review.gluster.org/15985 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 622787887735d9157feac6cc57745251baca7b78 Author: Anoop C S <anoopcs> Date: Thu Dec 1 15:05:06 2016 +0530 build: Use %{_datadir} rpm macro in spec file Change-Id: I18383b2a5f0ff5233d47715c2e91514b6c3f2b7c BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/15985 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: https://review.gluster.org/16517 (glusterfsd/gf_attach: Remove unused varibale) posted (#1) for review on master by Anoop C S (anoopcs)
COMMIT: https://review.gluster.org/16517 committed in master by Jeff Darcy (jdarcy) ------ commit b0012f81089258dc0b864db4b34afc3205c265df Author: Anoop C S <anoopcs> Date: Thu Feb 2 15:54:10 2017 +0530 glusterfsd/gf_attach: Remove unused varibale Change-Id: I1f2ae36c91bd0880a7f15aa73b7e0f462c7e7952 BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: https://review.gluster.org/16517 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> CentOS-regression: Gluster Build System <jenkins.org>
REVIEW: https://review.gluster.org/16540 (build: Honour prefix while evaluating localstatedir without a prefix) posted (#1) for review on master by Anoop C S (anoopcs)
REVIEW: https://review.gluster.org/16541 (build: Fix detection of uuid libs during configure) posted (#1) for review on master by Anoop C S (anoopcs)
REVIEW: https://review.gluster.org/16540 (build: Honour default prefix while evaluating localstatedir) posted (#2) for review on master by Anoop C S (anoopcs)
REVIEW: https://review.gluster.org/16541 (build: Fix detection of uuid libs during configure) posted (#2) for review on master by Anoop C S (anoopcs)
REVIEW: https://review.gluster.org/16624 (build: add gf_attach to .gitignore) posted (#1) for review on master by Niels de Vos (ndevos)
COMMIT: https://review.gluster.org/16541 committed in master by Niels de Vos (ndevos) ------ commit 7e59f937523b8f478216e0704d0ca533ec14b221 Author: Anoop C S <anoopcs> Date: Thu Feb 2 12:10:12 2017 +0000 build: Fix detection of uuid libs during configure This change cleans up the current logic for detecting the presence of uuid libs and avoids the following warning while executing configure script: . . . checking for UUID... yes checking uuid.h usability... yes checking uuid.h presence... no configure: WARNING: uuid.h: accepted by the compiler, rejected by the preprocessor! configure: WARNING: uuid.h: proceeding with the compiler's result checking for uuid.h... yes . . . Refer the following link for more details: https://www.gnu.org/software/autoconf/manual/autoconf.html#Present-But-Cannot-Be-Compiled Change-Id: Icc6e11097fed7c5a82ebd9d931b4e308f7d666c9 BUG: 1198849 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: https://review.gluster.org/16541 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos>
REVIEW: https://review.gluster.org/16639 (build: fix linking of 'gf_logdump' and 'gf_recon') posted (#1) for review on master by Niels de Vos (ndevos)
COMMIT: https://review.gluster.org/16639 committed in master by Niels de Vos (ndevos) ------ commit b8d827f4e7a289a7d6052e2596064b2f4ceb8d60 Author: Niels de Vos <ndevos> Date: Thu Feb 16 09:58:15 2017 +0100 build: fix linking of 'gf_logdump' and 'gf_recon' When linking the 'gf_recon' and 'gf_logdump' binaries on certain OS's (Debian?), the following error is returned and compilation aborts: Making all in src CCLD gf_recon Makefile:617: recipe for target 'gf_recon' failed Furher inspection showed this failure: /lib/x86_64-linux-gnu/libuuid.so.1: error adding symbols: DSO missing from command line 'gf_recon' and 'gf_logdump' link against libgfapi, and also need to pass the additional used libraries on the 'ld' commandline. Change-Id: I7401023f154dde46443f0186dda8ba749951234c Reported-by: chawlanikhil24 (on IRC) BUG: 1198849 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: https://review.gluster.org/16639 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report. glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html [2] https://www.gluster.org/pipermail/gluster-users/
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report. glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html [2] https://www.gluster.org/pipermail/gluster-users/