Bug 1225922

Summary:	Sharding - Skip update of block count and size for directories in readdirp callback
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1221104	Environment:
Last Closed:	2015-06-02 08:03:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1221104
Bug Blocks:

Description Krutika Dhananjay 2015-05-28 13:06:00 UTC

+++ This bug was initially created as a clone of Bug #1221104 +++

Description of problem:
Sharding translator, in readdirp callback, need not update the block count and file size in entry->d_stat if the inode is a directory. This BZ is to fix the bug.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-05-13 09:54:28 EDT ---

REVIEW: http://review.gluster.org/10772 (features/shard: Skip block count and size update for directories) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2015-05-17 10:34:34 EDT ---

REVIEW: http://review.gluster.org/10772 (features/shard: Skip block count and size update for directories) posted (#2) for review on master by Vijay Bellur (vbellur)

--- Additional comment from Anand Avati on 2015-05-18 13:06:08 EDT ---

REVIEW: http://review.gluster.org/10772 (features/shard: Skip block count and size update for directories) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2015-05-28 01:43:44 EDT ---

COMMIT: http://review.gluster.org/10772 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 58a687a8e0967393428bc5f93f0d32bbc3792f88
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 13 11:44:49 2015 +0200

    features/shard: Skip block count and size update for directories
    
    Change-Id: Iaa7022c95a8d9c9c471db025ec644e0bcc4eeb29
    BUG: 1221104
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10772
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Anand Avati 2015-05-28 13:10:50 UTC

REVIEW: http://review.gluster.org/10972 (features/shard: Skip block count and size update for directories) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-05-29 02:24:31 UTC

COMMIT: http://review.gluster.org/10972 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit bef714fa854536bf4a40d9d83a11945cb21248cb
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 13 11:44:49 2015 +0200

    features/shard: Skip block count and size update for directories
    
            Backport of: http://review.gluster.org/10772
    
    Change-Id: I3594641ef0bf6a17e1ceab3c9ad87ef18b981d2e
    BUG: 1225922
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/10972
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2015-06-02 08:03:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.1, please reopen this bug report.

glusterfs-3.7.1 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/1
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user