Bug 1226307

Summary: Volume start fails when glusterfs is source compiled with GCC v5.1.1
Product: [Community] GlusterFS Reporter: Anoop C S <anoopcs>
Component: geo-replicationAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: bugs, gluster-bugs, pellaeon
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.7.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1226853 (view as bug list) Environment:
Last Closed: 2016-05-28 06:04:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1226853    
Attachments:
Description Flags
Compile time warnings with GCC v5.1.1 none

Description Anoop C S 2015-05-29 12:13:53 UTC 
Description of problem:
When GlusterFS [master] is compiled and built on a fedora 22 machine with GCC v5.1.1, volume start fails with the following error in brick logs

[2015-05-28 07:12:42.176108] I [event-epoll.c:629:event_dispatch_epoll_worker] 0-epoll: Started thread with index 1
[2015-05-28 07:12:42.178705] W [xlator.c:192:xlator_dynload] 0-xlator: /usr/local/lib/glusterfs/3.8dev/xlator/features/changelog.so: undefined symbol: changelog_select_event
[2015-05-28 07:12:42.178721] E [graph.y:212:volume_type] 0-parser: Volume 'patchy-changelog', line 30: type 'features/changelog' is not valid or not found on this machine
[2015-05-28 07:12:42.178733] E [graph.y:321:volume_end] 0-parser: "type" not specified for volume patchy-changelog
[2015-05-28 07:12:42.178850] E [MSGID: 100026] [glusterfsd.c:2149:glusterfs_process_volfp] 0-: failed to construct the graph
[2015-05-28 07:12:42.178974] W [glusterfsd.c:1219:cleanup_and_exit] (--> 0-: received signum (0), shutting down

Version-Release number of selected component (if applicable):

GlusterFS (master) on fedora22 with GCC v5.1.1

How reproducible:
Always

Steps to Reproduce:
1. git clone master from review.gluster.org
2. Compile and install
3. Create a simple distributed volume
4. Start the volume

Actual results:
Volume start failed.

Expected results:
Volume start should be successful

Additional info:
Comment 1 Anand Avati 2015-05-29 12:18:08 UTC 
REVIEW: http://review.gluster.org/11004 (features/changelog: Remove inline keyword to avoid warnings (gcc v5.1.1)) posted (#1) for review on master by Anoop C S (achiraya)
Comment 2 Anoop C S 2015-05-29 12:23:54 UTC 
Created attachment 1032044 [details]
Compile time warnings with GCC v5.1.1
Comment 3 Anand Avati 2015-05-29 15:09:43 UTC 
REVIEW: http://review.gluster.org/11004 (features/changelog: Remove inline keyword to avoid warnings (gcc v5.1.1)) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)
Comment 4 Anand Avati 2015-06-01 08:56:31 UTC 
COMMIT: http://review.gluster.org/11004 committed in master by Venky Shankar (vshankar) 
------
commit eeb356584897ff778ffcbacff1c71d35d277b726
Author: Anoop C S <achiraya>
Date:   Fri May 29 16:33:09 2015 +0530

    features/changelog: Remove inline keyword to avoid warnings (gcc v5.1.1)
    
    When compiled with gcc5, following warnings were displayed
    and volume start failed:
    
    changelog-helpers.h:499:1: warning: inline function 'changelog_dispatch_event'
    declared but never defined
     changelog_dispatch_event (xlator_t *, changelog_priv_t *, changelog_event_t *);
    
    gf-changelog-journal-handler.c:692:17: warning: 'list_add_tail' is static but
    used in inline function 'gf_changelog_queue_journal' which is not static
                     list_add_tail (&entry->list, &jnl_proc->entries);
    
    Fix is to remove the keyword from function prototype and
    definitions.
    
    Change-Id: I188b35b7ca087a94d7a48a052b05a6d845e3b74b
    BUG: 1226307
    Signed-off-by: Anoop C S <achiraya>
    Reviewed-on: http://review.gluster.org/11004
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Venky Shankar <vshankar>
Comment 5 rjoseph 2015-06-02 12:41:12 UTC 
*** Bug 1226255 has been marked as a duplicate of this bug. ***
Comment 6 Nagaprasad Sathyanarayana 2015-10-25 14:46:22 UTC 
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.