Bug 1226428
Summary: | Dialog name is not saved for Catalog Bundle for Services | |||
---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | mkanoor | |
Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | |
Status: | CLOSED ERRATA | QA Contact: | Shveta <sshveta> | |
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 5.4.0 | CC: | akarol, cpelland, hkataria, jhardy, jprause, mfeifer, mkanoor, mpovolny, obarenbo | |
Target Milestone: | GA | |||
Target Release: | 5.4.0 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1227068 (view as bug list) | Environment: | ||
Last Closed: | 2015-06-16 13:03:02 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1227068 |
Description
mkanoor
2015-05-29 18:12:31 UTC
*** Bug 1226890 has been marked as a duplicate of this bug. *** Madhu, Can you provide the version in which this issue was observed? Thanks, Aziza It was the latest code on my dev machine, so I am guessing it should happen on 5.4 It was the latest code on my dev machine, so I am guessing it should happen on 5.4 New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/4dc8d771dfcd6badce33a4b4a98720b1f81d7d15 commit 4dc8d771dfcd6badce33a4b4a98720b1f81d7d15 Author: Harpreet Kataria <hkataria> AuthorDate: Mon Jun 1 12:49:03 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Jun 1 15:43:15 2015 -0400 Made changes to make Provisioning as required entry point. Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 vmdb/app/controllers/catalog_controller.rb | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=095d3d3691ab4e132ba0fb078172c8643f57ffd2 commit 095d3d3691ab4e132ba0fb078172c8643f57ffd2 Author: Harpreet Kataria <hkataria> AuthorDate: Mon Jun 1 12:49:03 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Jun 1 17:37:23 2015 -0400 Made changes to make Provisioning as required entry point. Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1227068 vmdb/app/controllers/catalog_controller.rb | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f2d6c32d88eaf0eba51e6aa2e546a5b59e4bd587 commit f2d6c32d88eaf0eba51e6aa2e546a5b59e4bd587 Merge: 3ec8f27 095d3d3 Author: Oleg Barenboim <obarenbo> AuthorDate: Thu Jun 4 14:15:37 2015 -0400 Commit: Oleg Barenboim <obarenbo> CommitDate: Thu Jun 4 14:15:37 2015 -0400 Merge branch '54z_catalog_item_dialog_save' into '5.4.z' Made changes to make Provisioning as required entry point. Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1227068 @dclarizio please review, this is a clean cherry-pick https://github.com/ManageIQ/manageiq/pull/3026 See merge request !93 vmdb/app/controllers/catalog_controller.rb | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) Fixed . Verified in 5.4.0.5.20150605150206_7daa1a8 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1100.html New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d4f24b5a3dab8da1404c9c9815d5a0c2f095120f commit d4f24b5a3dab8da1404c9c9815d5a0c2f095120f Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 2 11:09:24 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Jul 2 11:09:24 2015 -0400 Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f2d466fe953fe919ace32d9cd401813560a55a60 commit f2d466fe953fe919ace32d9cd401813560a55a60 Merge: 82aa947 d4f24b5 Author: Dan Clarizio <dclarizi> AuthorDate: Thu Jul 2 11:19:45 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Thu Jul 2 11:19:45 2015 -0400 Merge branch '53z_bz_1238036' into '5.3.z' Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 @dclarizio please review. This is not a clean cherry-pick original PR: https://github.com/ManageIQ/manageiq/pull/3026 some changes cherry-picked from: https://github.com/ManageIQ/manageiq/pull/2057 to get this fix working. See merge request !151 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 commit 9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 2 11:09:24 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 7 12:12:24 2015 -0400 Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 commit b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 Merge: 619d1f8 9f230df Author: Dan Clarizio <dclarizi> AuthorDate: Tue Jul 7 12:16:45 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Jul 7 12:16:45 2015 -0400 Merge branch '535_bz_1238036' into '5.3.5' Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) @dclarizio please review, this is a clean cherry-pick from 5.3.z commit MR for 5.3.z: http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/151 See merge request !161 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 commit 9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 2 11:09:24 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 7 12:12:24 2015 -0400 Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 commit b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 Merge: 619d1f8 9f230df Author: Dan Clarizio <dclarizi> AuthorDate: Tue Jul 7 12:16:45 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Jul 7 12:16:45 2015 -0400 Merge branch '535_bz_1238036' into '5.3.5' Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) @dclarizio please review, this is a clean cherry-pick from 5.3.z commit MR for 5.3.z: http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/151 See merge request !161 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) |