Bug 1238036 - 5.3.5 : service dialog doesn't get saved in catalog items.
Summary: 5.3.5 : service dialog doesn't get saved in catalog items.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.3.0
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: GA
: 5.3.5
Assignee: Harpreet Kataria
QA Contact: Dave Johnson
URL:
Whiteboard:
Depends On:
Blocks: 1238776
TreeView+ depends on / blocked
 
Reported: 2015-07-01 03:39 UTC by Shveta
Modified: 2015-07-15 12:56 UTC (History)
9 users (show)

Fixed In Version: 5.3.5.3
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1238776 (view as bug list)
Environment:
Last Closed: 2015-07-15 12:56:03 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
dialog not saved (126.87 KB, image/png)
2015-07-01 03:39 UTC, Shveta
no flags Details
ordering dialog (104.52 KB, image/png)
2015-07-01 03:39 UTC, Shveta
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1223 0 normal SHIPPED_LIVE cfme (5.3.5) bug fix and enhancement update 2015-07-15 16:54:20 UTC

Description Shveta 2015-07-01 03:39:03 UTC
Created attachment 1044867 [details]
dialog not saved

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.create a service dialog. Create a catalog item and select the dialog 
2. Save 
3. catalog item shows "No dialog"
4. Order catalog item from service catalogs "Ordering dialog not available" is shown

Actual results:


Expected results:


Additional info:
 	5.3.5.1.20150630091250_5515226

Comment 1 Shveta 2015-07-01 03:39:35 UTC
Created attachment 1044868 [details]
ordering dialog

Comment 5 Shveta 2015-07-01 15:36:52 UTC
works with workaround.

Comment 7 CFME Bot 2015-07-02 15:21:55 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d4f24b5a3dab8da1404c9c9815d5a0c2f095120f

commit d4f24b5a3dab8da1404c9c9815d5a0c2f095120f
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jul 2 11:09:24 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Jul 2 11:09:24 2015 -0400

    Made changes to make Provisioning as required entry point.
    
    - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z
    - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1226428
    (cherry picked from commit 4dc8d77)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238036

 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++---------
 vmdb/app/models/service_template.rb        |  9 ---------
 2 files changed, 19 insertions(+), 18 deletions(-)

Comment 8 CFME Bot 2015-07-02 15:22:03 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f2d466fe953fe919ace32d9cd401813560a55a60

commit f2d466fe953fe919ace32d9cd401813560a55a60
Merge: 82aa947 d4f24b5
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Jul 2 11:19:45 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Jul 2 11:19:45 2015 -0400

    Merge branch '53z_bz_1238036' into '5.3.z'
    
    Made changes to make Provisioning as required entry point.
    
    - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z
    - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1226428
    (cherry picked from commit 4dc8d77)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238036
    
    @dclarizio please review. This is not a clean cherry-pick
    original PR: https://github.com/ManageIQ/manageiq/pull/3026
    some changes cherry-picked from: https://github.com/ManageIQ/manageiq/pull/2057 to get this fix working.
    
    See merge request !151

 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++---------
 vmdb/app/models/service_template.rb        |  9 ---------
 2 files changed, 19 insertions(+), 18 deletions(-)

Comment 11 CFME Bot 2015-07-07 16:21:48 UTC
New commit detected on cfme/5.3.5:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826

commit 9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jul 2 11:09:24 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jul 7 12:12:24 2015 -0400

    Made changes to make Provisioning as required entry point.
    
    - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z
    - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1226428
    (cherry picked from commit 4dc8d77)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238036
    (cherry picked from commit d4f24b5)

 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++---------
 vmdb/app/models/service_template.rb        |  9 ---------
 2 files changed, 19 insertions(+), 18 deletions(-)

Comment 12 CFME Bot 2015-07-07 16:21:55 UTC
New commit detected on cfme/5.3.5:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b8e776eef548b0524f9dd5a0ce4e68fa9beecb18

commit b8e776eef548b0524f9dd5a0ce4e68fa9beecb18
Merge: 619d1f8 9f230df
Author:     Dan Clarizio <dclarizi>
AuthorDate: Tue Jul 7 12:16:45 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Tue Jul 7 12:16:45 2015 -0400

    Merge branch '535_bz_1238036' into '5.3.5'
    
    Made changes to make Provisioning as required entry point.
    
    - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z
    - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1226428
    (cherry picked from commit 4dc8d77)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238036
    (cherry picked from commit d4f24b5)
    
    @dclarizio please review, this is a clean cherry-pick from 5.3.z commit
    MR for 5.3.z: http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/151
    
    See merge request !161

 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++---------
 vmdb/app/models/service_template.rb        |  9 ---------
 2 files changed, 19 insertions(+), 18 deletions(-)

Comment 13 CFME Bot 2015-07-07 17:15:31 UTC
New commit detected on cfme/5.3.5:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826

commit 9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jul 2 11:09:24 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jul 7 12:12:24 2015 -0400

    Made changes to make Provisioning as required entry point.
    
    - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z
    - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1226428
    (cherry picked from commit 4dc8d77)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238036
    (cherry picked from commit d4f24b5)

 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++---------
 vmdb/app/models/service_template.rb        |  9 ---------
 2 files changed, 19 insertions(+), 18 deletions(-)

Comment 14 CFME Bot 2015-07-07 17:15:39 UTC
New commit detected on cfme/5.3.5:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b8e776eef548b0524f9dd5a0ce4e68fa9beecb18

commit b8e776eef548b0524f9dd5a0ce4e68fa9beecb18
Merge: 619d1f8 9f230df
Author:     Dan Clarizio <dclarizi>
AuthorDate: Tue Jul 7 12:16:45 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Tue Jul 7 12:16:45 2015 -0400

    Merge branch '535_bz_1238036' into '5.3.5'
    
    Made changes to make Provisioning as required entry point.
    
    - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z
    - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1226428
    (cherry picked from commit 4dc8d77)
    https://bugzilla.redhat.com/show_bug.cgi?id=1238036
    (cherry picked from commit d4f24b5)
    
    @dclarizio please review, this is a clean cherry-pick from 5.3.z commit
    MR for 5.3.z: http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/151
    
    See merge request !161

 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++---------
 vmdb/app/models/service_template.rb        |  9 ---------
 2 files changed, 19 insertions(+), 18 deletions(-)

Comment 15 Shveta 2015-07-09 03:34:01 UTC
Fixed.
Verifiedin 5.3.5.3.20150708141502_b69b688

Comment 17 errata-xmlrpc 2015-07-15 12:56:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1223.html


Note You need to log in before you can comment on or make changes to this bug.