Bug 1226666

Summary:	BitRot :- Handle brick re-connection sanely in bitd/scrub process
Product:	[Community] GlusterFS	Reporter:	Rachana Patel <rachana7>
Component:	bitrot	Assignee:	Venky Shankar <vshankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	3.7.0	CC:	bugs, vshankar
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1231619 (view as bug list)		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1226830, 1231617, 1231619, 1232309

Description Rachana Patel 2015-05-31 15:57:05 UTC

Description: 
============
Upon brick disconnection (and reconnection), bitrot
daemons should able to recover sanely by handling the events as
cleaning up (or initing) as required.

Comment 1 Rachana Patel 2015-05-31 15:57:29 UTC

shall update detail steps ASAP

Comment 2 Anand Avati 2015-06-11 14:52:34 UTC

REVIEW: http://review.gluster.org/11149 (features/bitrot: handle scrub states via state machine) posted (#3) for review on master by Venky Shankar (vshankar)

Comment 3 Anand Avati 2015-06-11 14:52:36 UTC

REVIEW: http://review.gluster.org/11148 (features/bitrot: cleanup, v2) posted (#3) for review on master by Venky Shankar (vshankar)

Comment 4 Anand Avati 2015-06-12 03:27:34 UTC

REVIEW: http://review.gluster.org/11148 (features/bitrot: cleanup, v2) posted (#4) for review on master by Venky Shankar (vshankar)

Comment 5 Anand Avati 2015-06-15 04:20:04 UTC

REVIEW: http://review.gluster.org/11148 (features/bitrot: cleanup, v2) posted (#5) for review on master by Venky Shankar (vshankar)

Comment 6 Anand Avati 2015-06-25 07:16:58 UTC

REVIEW: http://review.gluster.org/11398 (tests/bitrot: Scrub state change tests) posted (#1) for review on release-3.7 by Venky Shankar (vshankar)

Comment 7 Anand Avati 2015-06-27 03:45:22 UTC

COMMIT: http://review.gluster.org/11398 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 58cd192a78e53c227a6998ff217a40dea14957ad
Author: Venky Shankar <vshankar>
Date:   Wed Jun 17 22:59:17 2015 +0530

    tests/bitrot: Scrub state change tests
    
        Backport of http://review.gluster.org/11290
    
    Change-Id: Ibb4b503e7d723c86ac381ad3747b1198334bd6ad
    BUG: 1226666
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/11398
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 8 Anand Avati 2015-07-06 07:27:37 UTC

REVIEW: http://review.gluster.org/11541 (features/bitrot: handle scrub states via state machine) posted (#1) for review on release-3.7 by Venky Shankar (vshankar)

Comment 9 Anand Avati 2015-07-06 07:28:00 UTC

REVIEW: http://review.gluster.org/11542 (features/bitrot: convert pending gf_log() to gf_msg()) posted (#1) for review on release-3.7 by Venky Shankar (vshankar)

Comment 10 Anand Avati 2015-07-09 10:13:31 UTC

COMMIT: http://review.gluster.org/11540 committed in release-3.7 by Raghavendra Bhat (raghavendra) 
------
commit 2874ee4d65185a607f1f646fc88ba8eb400aaa9a
Author: Venky Shankar <vshankar>
Date:   Thu Jun 4 08:50:48 2015 +0530

    features/bitrot: cleanup, v2
    
        Backport of http://review.gluster.org/11148
    
    This patch uses "cleanup, v1" infrastrcuture to cleanup scrubber
    (data structures, threads, timers, etc..) on brick disconnection.
    Signer is not cleaned up yet: probably would be done as part of
    another patch.
    
    Change-Id: I78a92b8a7f02b2f39078aa9a5a6b101fc499fd70
    BUG: 1226666
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/11540
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>

Comment 11 Anand Avati 2015-07-09 10:29:07 UTC

COMMIT: http://review.gluster.org/11541 committed in release-3.7 by Raghavendra Bhat (raghavendra) 
------
commit a90b7c5d640bc7bf1bd648c69127fd1953e27421
Author: Venky Shankar <vshankar>
Date:   Tue Jun 9 10:02:11 2015 +0530

    features/bitrot: handle scrub states via state machine
    
        Backport of http://review.gluster.org/11149
    
    A bunch of command line options for scrubber tempted the use of
    state machine to track current state of scrubber under various
    circumstances where the options could be in effect.
    
    Change-Id: Id614bb2e6af30a90d2391ea31ae0a3edeb4e0d69
    BUG: 1226666
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/11541
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Tested-by: Gluster Build System <jenkins.com>

Comment 12 Anand Avati 2015-07-09 10:31:40 UTC

COMMIT: http://review.gluster.org/11542 committed in release-3.7 by Raghavendra Bhat (raghavendra) 
------
commit 911b4a37a67b6759ddce55e1b3dbcd0641805f76
Author: Venky Shankar <vshankar>
Date:   Thu Jun 25 12:07:24 2015 +0530

    features/bitrot: convert pending gf_log() to gf_msg()
    
        Backport of http://review.gluster.org/11396
    
    Change-Id: Idfd245327b485459ccbda503510b8ca0127bb66c
    BUG: 1226666
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/11542
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 13 Kaushal 2015-07-30 09:48:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 14 Kaushal 2015-07-30 09:48:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 15 Kaushal 2015-07-30 09:48:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 16 Kaushal 2015-07-30 09:51:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user