Bug 1227144

Summary:	[GSS](6.4.z) standalone.conf is marked %config not %config(noreplace) in RPM metadata
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	James Livingston <jlivings>
Component:	RPMs	Assignee:	Permaine Cheung <pcheung>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Katerina Odabasi <kanovotn>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.4.0	CC:	aogburn, bbaranow, bmaxwell, fnasser, ihradek, jbaesner, joallen, mmiura, pgier, ppalaga, ppenicka, rstancel
Target Milestone:	CR3	Keywords:	Reopened
Target Release:	EAP 6.4.15
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-19 08:07:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1419353

Description James Livingston 2015-06-02 01:28:26 UTC

Bug 979125 change the RPM spec file so that standalone.conf was marked as a %config file so that it was not silently overwritten when upgrading.

Since that is a file with expect many users to edit, it would probably be better set to %config(noreplace), so that the new version is created as a .rpmnew file and the existing configuration untouched.

Right now (with %config) we overwrite the settings, although a backup saves to .rpmsave, and this can lead to JBoss or customer applications not working correctly because they are missing the custom settings.

Comment 2 Peter Palaga 2016-08-08 18:37:55 UTC

Hi Fernando, could you please tell me in which git repo the rpmspec files reside? I'd like to check if this issue is still valid.

Comment 3 Fernando Nasser 2016-08-08 19:00:11 UTC

This is the dist-git repo "jbossas-standalone" branch jb-eap-6.4-rhel-6 :

%config %{jbhomedir}/bin/standalone.conf

So I guess the answer is that this change was not implemented.  
I don't see it ever getting the 3-acks BTW.

Comment 6 Fernando Nasser 2016-08-09 13:29:07 UTC

A bit late to change the behaviour for 6.4.x, we are already at .10.

It has been fixed in EAP 7 instead:

%config(noreplace) %{confdir}/%{standaloneService}.conf

I suggest we close this as obsolete.

Comment 7 Peter Palaga 2016-08-09 13:34:13 UTC

Brad, could we close as WONTFIX as per c#6 ?

Comment 12 Fernando Nasser 2017-04-26 12:30:50 UTC

It is easy to mark it as noreplace and perhaps it should have been marked like that from 6.0.1.

It *is* a significant change of behaviour though, so I will wait for the 3-acks and for it to be added to a CP payload before making the change.

P.S.: I am re-assigning this to Permaine as I am no longer in the EAP team.

Comment 14 Permaine Cheung 2017-04-27 15:01:07 UTC

Fixed, will be in 6.4.15 CR3.

Comment 15 Ivo Hradek 2017-05-16 13:48:09 UTC

Confirmed, fix is indeed in CP15, hence I'm verifying this for EAP 6.4.15.CP.CR3;

Comment 16 Petr Penicka 2017-05-19 08:07:33 UTC

Released on May 18 as part of EAP 6.4.15.