Bug 1227144 - [GSS](6.4.z) standalone.conf is marked %config not %config(noreplace) in RPM metadata
Summary: [GSS](6.4.z) standalone.conf is marked %config not %config(noreplace) in RPM ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: RPMs
Version: 6.4.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: CR3
: EAP 6.4.15
Assignee: Permaine Cheung
QA Contact: Katerina Odabasi
URL:
Whiteboard:
Depends On:
Blocks: eap6415-payload
TreeView+ depends on / blocked
 
Reported: 2015-06-02 01:28 UTC by James Livingston
Modified: 2020-07-16 08:33 UTC (History)
12 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-05-19 08:07:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBEAP-10565 0 Critical Verified RPM - yum update overrides EAP_HOME/bin/[standalone|domain].conf files 2018-01-26 08:20:52 UTC
Red Hat Issue Tracker JBEAP-10572 0 Critical Ready for QA [GSS](7.0.z) RPM - yum update overrides EAP_HOME/bin/[standalone|domain].conf files 2018-01-26 08:20:52 UTC

Description James Livingston 2015-06-02 01:28:26 UTC
Bug 979125 change the RPM spec file so that standalone.conf was marked as a %config file so that it was not silently overwritten when upgrading.

Since that is a file with expect many users to edit, it would probably be better set to %config(noreplace), so that the new version is created as a .rpmnew file and the existing configuration untouched.

Right now (with %config) we overwrite the settings, although a backup saves to .rpmsave, and this can lead to JBoss or customer applications not working correctly because they are missing the custom settings.

Comment 2 Peter Palaga 2016-08-08 18:37:55 UTC
Hi Fernando, could you please tell me in which git repo the rpmspec files reside? I'd like to check if this issue is still valid.

Comment 3 Fernando Nasser 2016-08-08 19:00:11 UTC
This is the dist-git repo "jbossas-standalone" branch jb-eap-6.4-rhel-6 :

%config %{jbhomedir}/bin/standalone.conf

So I guess the answer is that this change was not implemented.  
I don't see it ever getting the 3-acks BTW.

Comment 6 Fernando Nasser 2016-08-09 13:29:07 UTC
A bit late to change the behaviour for 6.4.x, we are already at .10.

It has been fixed in EAP 7 instead:

%config(noreplace) %{confdir}/%{standaloneService}.conf

I suggest we close this as obsolete.

Comment 7 Peter Palaga 2016-08-09 13:34:13 UTC
Brad, could we close as WONTFIX as per c#6 ?

Comment 12 Fernando Nasser 2017-04-26 12:30:50 UTC
It is easy to mark it as noreplace and perhaps it should have been marked like that from 6.0.1.

It *is* a significant change of behaviour though, so I will wait for the 3-acks and for it to be added to a CP payload before making the change.

P.S.: I am re-assigning this to Permaine as I am no longer in the EAP team.

Comment 14 Permaine Cheung 2017-04-27 15:01:07 UTC
Fixed, will be in 6.4.15 CR3.

Comment 15 Ivo Hradek 2017-05-16 13:48:09 UTC
Confirmed, fix is indeed in CP15, hence I'm verifying this for EAP 6.4.15.CP.CR3;

Comment 16 Petr Penicka 2017-05-19 08:07:33 UTC
Released on May 18 as part of EAP 6.4.15.


Note You need to log in before you can comment on or make changes to this bug.