Bug 1227449

Summary:	Fix deadlock in timer-wheel del_timer() API
Product:	[Community] GlusterFS	Reporter:	Venky Shankar <vshankar>
Component:	core	Assignee:	Venky Shankar <vshankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:	GlusterFS Bugs list <gluster-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, ndevos, vbellur
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1227611 1231026 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:07:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1227611, 1231026

Description Venky Shankar 2015-06-02 16:52:29 UTC

Description of problem:
Deadlock in timer-wheel (contrib/timer-wheel) del_timer() API.

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Comment 1 Anand Avati 2015-06-02 16:57:05 UTC

REVIEW: http://review.gluster.org/11050 (contrib/timer-wheel: fix deadlock in del_timer()) posted (#1) for review on master by Venky Shankar (vshankar)

Comment 2 Anand Avati 2015-06-03 03:24:35 UTC

COMMIT: http://review.gluster.org/11050 committed in master by Venky Shankar (vshankar) 
------
commit 9a314fa22667bf5afe56e63e73f4b0f50cd291f6
Author: Venky Shankar <vshankar>
Date:   Tue Jun 2 21:49:13 2015 +0530

    contrib/timer-wheel: fix deadlock in del_timer()
    
    commit eaf3bfa added mod_timers() and successfully screwed up
    del_timer() by incorrectly wrapping it within double lock
    blocks.
    
    del_timer() was included before the above commit for the sake of
    timer API completion, thankfully noone used it till now.
    
    Change-Id: I07a454a216cf09dbb84777a23630e74a1e7f2830
    BUG: 1227449
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/11050
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Nagaprasad Sathyanarayana 2015-10-25 15:13:20 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 4 Niels de Vos 2016-06-16 13:07:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user