Bug 1227576

Summary:	libglusterfs: Copy _all_ members of gf_dirent_t in entry_copy()
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	core	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1226551	Environment:
Last Closed:	2015-06-20 09:49:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1226551
Bug Blocks:

Description Krutika Dhananjay 2015-06-03 04:12:00 UTC

+++ This bug was initially created as a clone of Bug #1226551 +++

Description of problem:

Per discussion @ http://review.gluster.org/#/c/10809/1/xlators/features/shard/src/shard.c, the function entry_copy() must also copy d_len member and the per-entry dict if it is present, into the dst dirent.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-06-01 02:41:20 EDT ---

REVIEW: http://review.gluster.org/11026 (libglusterfs: Copy d_len and dict as well into dst dirent) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2015-06-01 07:23:36 EDT ---

REVIEW: http://review.gluster.org/11026 (libglusterfs: Copy d_len and dict as well into dst dirent) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2015-06-02 09:52:38 EDT ---

REVIEW: http://review.gluster.org/11026 (libglusterfs: Copy d_len and dict as well into dst dirent) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2015-06-02 23:46:22 EDT ---

COMMIT: http://review.gluster.org/11026 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit e1d9895ba6f7763ba4602094f6516a6ab4a054d4
Author: Krutika Dhananjay <kdhananj>
Date:   Mon Jun 1 11:55:29 2015 +0530

    libglusterfs: Copy d_len and dict as well into dst dirent
    
    Also, added memory allocation failure checks in light of the
    comments received @
    http://review.gluster.org/#/c/10809/2/libglusterfs/src/gf-dirent.c, and
    http://review.gluster.org/#/c/10809/1/xlators/features/shard/src/shard.c
    
    Change-Id: Ie4092218545c8f4f8a0e6cc1fec6ba37bbbf2620
    BUG: 1226551
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11026
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Anand Avati 2015-06-03 04:14:36 UTC

REVIEW: http://review.gluster.org/11052 (libglusterfs: Copy d_len and dict as well into dst dirent) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-06-04 01:58:26 UTC

COMMIT: http://review.gluster.org/11052 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 140b4fdefa21c00af3e6015fed86c632683ab01f
Author: Krutika Dhananjay <kdhananj>
Date:   Mon Jun 1 11:55:29 2015 +0530

    libglusterfs: Copy d_len and dict as well into dst dirent
    
            Backport of: http://review.gluster.org/11026
    
    Also, added memory allocation failure checks in light of the
    comments received @
    http://review.gluster.org/#/c/10809/2/libglusterfs/src/gf-dirent.c, and
    http://review.gluster.org/#/c/10809/1/xlators/features/shard/src/shard.c
    
    Change-Id: Iad4736bba69e6977390f76d0c9eb64217a005b80
    BUG: 1227576
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11052
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Niels de Vos 2015-06-20 09:49:31 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user