Bug 1227937

Tina - This ticket needs details about the issue so it can be tested and validated.

Internal testing uncovered an issue where the dialog_parser automate method was creating an incorrect value for tag_control dialog entries which would result in incorrect values be passed to provisioning.

Validation steps:
1. Create a service dialog:
   Name: tag_0_test
   Type: tag_control
   Category: department
2. Create a single service item specifying the dialog created in step 1.
3. Provision service, selecting 2 department entries.
4. Check automation.log for "parsed_dialog_tags".

Note - before applying the fix, you should see the values of "true" as shown 

parsed_dialog_tags: "---\n0:test:\n - true\n - true\n2:\n :stuff: tag 2\n3:\n :stuff: tag_3_stuff\n"

Note - after applying the fix, you should see the values you selected. I selected accounting and automotive as shown below: 

parsed_dialog_tags: "---\n0:\n :tagcontrol:\n - qa\n :test:\n - accounting\n - automotive\n - communication\n2:\n :stuff: tag 2\n3:\n :stuff: tag_3_stuff\n"

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/c93124df26310cea59af389644b9c4f4a7a166e0

commit c93124df26310cea59af389644b9c4f4a7a166e0
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Wed Jun 3 17:36:00 2015 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Wed Jun 3 17:36:00 2015 -0400

    Fix automate service dialog_parsing issue.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1227937

 .../StateMachines/Methods.class/__methods__/dialog_parser.rb            | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=6c5930fce2b20f4d7a5d3f472b94b660262bfd2d

commit 6c5930fce2b20f4d7a5d3f472b94b660262bfd2d
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Wed Jun 3 17:36:00 2015 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Thu Jun 4 16:56:36 2015 -0400

    Fix automate service dialog_parsing issue.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1227937

 .../StateMachines/Methods.class/__methods__/dialog_parser.rb            | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a2ba25cfa312d876eca57b44ac4368ff6e593b84

commit a2ba25cfa312d876eca57b44ac4368ff6e593b84
Merge: 950098c 6c5930f
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Tue Jun 16 11:53:08 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Tue Jun 16 11:53:08 2015 -0400

    Merge branch 'bz_1228399' into '5.4.z'
    
    Fix automate service dialog_parsing issue.
    
    Clean cherry-pick.
    
    PR
    https://github.com/ManageIQ/manageiq/pull/3053
    
    BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1228399
    
    Cloned from:
    https://bugzilla.redhat.com/show_bug.cgi?id=1227937
    
    See merge request !102

 .../StateMachines/Methods.class/__methods__/dialog_parser.rb            | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

There is still some sort of problem.  I can't even get the field to display correctly on the order.  I see the label ok, but the select box never appears.  I checked 5509 and 550ten.  Finally went back to a 5.4.3 instance just to make sure I wasn't doing something stupid and it worked fine.

Please take a minute to check my work.  The bother look the same.  Everything is called tab_something

This is 5.4.3 https://10.8.59.221
This is 5.5.0.10 https://10.16.7.101/catalog/explorer

Hi Jeff,

Yes, I see the issue you're experiencing in 5.5. 
Could you open a ticket on it?

You could try importing the service dialog from the 5.4.3 environment, but I suspect it won't help. We might have to wait for that issue to be resolved before validating this fix.

Thanks,
Tina

Verification Block by https://bugzilla.redhat.com/show_bug.cgi?id=1282949

We can leave this here for a while.  I'll keep an eye on both.

Closing this out for now, we will make sure a test case is in place and verify once the blocker is fixed.