Bug 1228411

New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f65c0108542ed467421aaf1704d2bfd34d8a6675

commit f65c0108542ed467421aaf1704d2bfd34d8a6675
Merge: a2ba25c dfc9a93
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Tue Jun 16 15:33:15 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Tue Jun 16 15:33:15 2015 -0400

    Merge branch 'bz_1228411' into '5.4.z'
    
    Service dialog - fix issue where vm_name is not getting set properly.
    
    Fix problem where options were not getting set properly on the provision task.
    
    Clean cherry-pick.
    
    PR
    https://github.com/ManageIQ/manageiq/pull/3052
    
    BZ
    https://bugzilla.redhat.com/show_bug.cgi?id=1228411
    
    Original BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1221386
    
    See merge request !103

 .../Methods.class/__methods__/catalogiteminitialization.rb            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Hi Pete,

I can see how that would be very confusing.  I've included additional information regarding the naming schema with dialog information taken from:
https://bugzilla.redhat.com/show_bug.cgi?id=1225930

Besides the dialog naming/numbering schema, there are these special per service attributes:
service_name           <---- to override service name
service_description    <---- to override service description
vm_name or target_name <---- to override the vm name

The vm_name override doesn't make sense for a multi-vm service bundle. So, a correction for validation on this issue would be to create a service with a single instance and specify the vm_name to override.

*note - A user could specify the vm_names for multiple service items by using the dialog_option_1_vm_name, dialog_option_2_vm_name, and so on. 

.......
https://bugzilla.redhat.com/show_bug.cgi?id=1225930 - detail

All dialog entries are automatically prefixed with "dialog_" so it is not necessary to add the dialog prefix when creating the service dialog attributes. 

The dialog processing is supposed to pass the correct information to the appropriate item(s). This is accomplished by the use of a naming and numbering schema.  
In addition to custom dialog names, attribute names containing "option" and "tag" could have special meaning.
The dialog numbering schema is setup so dialog attributes with zero key entries are global and passed to all service items. The non-zero key entries are applied to the service items that have a matching provision index. Service item 1 will have options for 0 and 1, service item 2 will have options for 0 and 2, …..
The combination of naming(options and tags) and numbering(global vs item specific) is key to setting up the dialog attributes:
...............

Let me know if you have any questions.

Thanks,
Tina

Verified 5.4.0.1

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1511.html