Bug 1221386 - dialog values do not override vm_name
Summary: dialog values do not override vm_name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.5.0
Assignee: Tina Fitzgerald
QA Contact: Dmitry Misharov
URL:
Whiteboard:
Depends On:
Blocks: 1228411
TreeView+ depends on / blocked
 
Reported: 2015-05-13 22:31 UTC by Shveta
Modified: 2018-06-07 08:45 UTC (History)
8 users (show)

Fixed In Version: 5.5.0.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1228411 (view as bug list)
Environment:
Last Closed: 2015-12-08 13:09:07 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2551 0 normal SHIPPED_LIVE Moderate: CFME 5.5.0 bug fixes and enhancement update 2015-12-08 17:58:09 UTC

Description Shveta 2015-05-13 22:31:46 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a service dialog
tag_0_attr1       <---- use tagcontrol - make multiselect like department
option_0_attr2    <---- contents unimportant - text box is fine
tag_1_attr3       <---- use tagcontrol - make single value like location
option_1_attr4    <---- contents unimportant - text box is fine
tag_2_attr5       <---- contents unimportant - text box is fine
option_2_attr6    <---- contents unimportant - text box is fine
tag_3_attr7       <---- contents unimportant - text box is fine
option_3_attr8    <---- contents unimportant - text box is fine

plus 3 special attributes:
service_name           <---- to override service name
service_description    <---- to override service description
vm_name or target_name <---- to override the vm name
==========================================

2. Create 3 service catalog items(provider type doesn't matter), specify:
* display in catalog
* Provisioning entrypoint of /Service/Provisioning/Statemachines/ServiceProvision_Template/Catalogiteminitialization 

3. Create a service bundle
* display in catalog
* containing the 3 items above
* Provisioning entrypoint of /Service/Provisioning/Statemachines/ServiceProvision_Template/Catalogbundleinitialization 
Important - Specify the provision order for 3 items. This is the value that is going to match the dialog number scheme described above. 

4.
Edit 
/Service/Provisioning/Statemachines/ServiceProvision_Template/Catalogbundleinitialization instance 

move this:  
/Service/Provisioning/StateMachines/Methods/CatalogBundleInitialization
to pre2 slot

add this to pre1 slot
/Service/Provisioning/StateMachines/Methods/DialogParser

Edit 
/Service/Provisioning/Statemachines/ServiceProvision_Template/Catalogiteminitialization instance 

move this:  
/Service/Provisioning/StateMachines/Methods/CatalogItemInitialization
to pre2 slot

add this to pre1 slot
/Service/Provisioning/StateMachines/Methods/DialogParser

Finally, provision:
catalog item and check results:
catalog bundle and check results:
 
*service_name should be named specified in dialog
*service_description should be description specified in dialog
*vm_name should be vm_name specified in dialog
Check provisioned vm for tags specified and automation.log for further detail.

Actual results:
Vm_name doesn't change

Expected results:


Additional info:
5.4.0.0.26.20150511144816_f924bd4

Comment 2 Dave Johnson 2015-05-14 15:34:32 UTC
Shveta, any idea if there is a equivalent 5.3 issue?  We need to find and link it.

Comment 3 Shveta 2015-05-18 19:06:11 UTC
This feature was not available in 5.3

Comment 4 CFME Bot 2015-06-04 20:20:59 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/0e3de10a3c1c95997e49136ac85633d8137ec6fd

commit 0e3de10a3c1c95997e49136ac85633d8137ec6fd
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Wed Jun 3 16:56:58 2015 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Wed Jun 3 16:56:58 2015 -0400

    Fix problem where options were not getting set properly on the
    provision task.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221386

 .../Methods.class/__methods__/catalogiteminitialization.rb            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 5 CFME Bot 2015-06-16 19:36:27 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=dfc9a93cf404d0fee9aa12d94ef9873385711e6c

commit dfc9a93cf404d0fee9aa12d94ef9873385711e6c
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Wed Jun 3 16:56:58 2015 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Thu Jun 4 17:17:42 2015 -0400

    Fix problem where options were not getting set properly on the
    provision task.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221386

 .../Methods.class/__methods__/catalogiteminitialization.rb            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 6 CFME Bot 2015-06-16 19:36:35 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f65c0108542ed467421aaf1704d2bfd34d8a6675

commit f65c0108542ed467421aaf1704d2bfd34d8a6675
Merge: a2ba25c dfc9a93
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Tue Jun 16 15:33:15 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Tue Jun 16 15:33:15 2015 -0400

    Merge branch 'bz_1228411' into '5.4.z'
    
    Service dialog - fix issue where vm_name is not getting set properly.
    
    Fix problem where options were not getting set properly on the provision task.
    
    Clean cherry-pick.
    
    PR
    https://github.com/ManageIQ/manageiq/pull/3052
    
    BZ
    https://bugzilla.redhat.com/show_bug.cgi?id=1228411
    
    Original BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1221386
    
    See merge request !103

 .../Methods.class/__methods__/catalogiteminitialization.rb            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 7 Milan Falešník 2015-11-24 12:54:33 UTC
Checked in 5.5.0.11, service_name, service_description and vm_name override their respective values.

Although if I do it exactly as the steps are, I get an error when provisioning the bundle. But everything in bundle is set, there is just only one machine running. Since this is not directly related to this BZ, moving to verified but setting a needinfo just in case I am wrong.

Comment 8 Tina Fitzgerald 2015-12-07 14:48:59 UTC
Hi Milan,

I'm curious why your bundle is failing. 
Does the catalog item provision succeed?  

Can I have access to your environment to check it out?

Thanks,
Tina

Comment 11 errata-xmlrpc 2015-12-08 13:09:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551


Note You need to log in before you can comment on or make changes to this bug.