Bug 1228510

Summary:	Building packages on RHEL-5 based distributions fails
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	packaging	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	amukherj, bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-20 09:50:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1222317
Bug Blocks:	1227206, 1230114

Description Niels de Vos 2015-06-05 06:03:07 UTC

+++ This bug was initially created as a clone of Bug #1222317 +++

Description of problem:
There are several issues while building glusterfs on RHEL-5. New features introduced for 3.7.x cause the building of RPMs to break.

Steps to reproduce:
1. make dist
2. rpmbuild -ts glusterfs-3.8dev.tar.gz
3. mock -r epel-5-x86_64 /path/to/glustersfs-3.8de-0.*.src.rpm

Additional comments:
Multiple failures, the above will abort on the first problem.

--- Additional comment from Anand Avati on 2015-06-02 16:23:33 CEST ---

REVIEW: http://review.gluster.org/10803 (build: fix compiling on older distributions) posted (#8) for review on master by Jeff Darcy (jdarcy)

--- Additional comment from Anand Avati on 2015-06-02 16:23:35 CEST ---

REVIEW: http://review.gluster.org/11037 (stripe: fix use-after-free) posted (#2) for review on master by Jeff Darcy (jdarcy)

--- Additional comment from Anand Avati on 2015-06-03 15:53:47 CEST ---

COMMIT: http://review.gluster.org/10803 committed in master by Vijay Bellur (vbellur) 
------
commit 0209b18fd65f9df5ebd0a8764ebf864d0d392998
Author: Niels de Vos <ndevos>
Date:   Sun May 17 15:26:03 2015 +0200

    build: fix compiling on older distributions
    
    data-tiering is disabled on RHEL-5 because it depends on a too new
    SQLite version.
    
    This change also prevents installing some of files that are used by
    geo-replication, which is also not available on RHEL-5. geo-replication
    depends on a too recent version of Python.
    
    Due to an older version of OpenSSL, some of the newer functions can not
    be used. A fallback to previous functions is done. Unfortunately RHEL-5
    does not seem to have TLSv1.2 support, so only older versions can be
    used.
    
    Change-Id: I672264a673f5432358d2e83b17e2a34efd9fd913
    BUG: 1222317
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/10803
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2015-06-05 07:13:34 UTC

REVIEW: http://review.gluster.org/11096 (build: fix compiling on older distributions) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2015-06-08 04:20:40 UTC

REVIEW: http://review.gluster.org/11096 (build: fix compiling on older distributions) posted (#2) for review on release-3.7 by Atin Mukherjee (amukherj)

Comment 3 Anand Avati 2015-06-09 17:07:14 UTC

REVIEW: http://review.gluster.org/11142 (rpm: correct date and order of entries in the %changelog) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 4 Anand Avati 2015-06-10 03:39:53 UTC

REVIEW: http://review.gluster.org/11145 (stripe: fix use-after-free) posted (#2) for review on release-3.7 by Krishnan Parthasarathi (kparthas)

Comment 5 Anand Avati 2015-06-10 12:38:32 UTC

COMMIT: http://review.gluster.org/11145 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit d4f9640a08c10beb4cedfefba0a91528b47867e7
Author: Jeff Darcy <jdarcy>
Date:   Mon Jun 1 15:21:00 2015 -0400

    stripe: fix use-after-free
    
    Pretty much a classic case.  STRIPE_STACK_UNWIND frees the "local"
    structure.  In the "virtual xattr" path, used for lock recovery among
    other things, we were calling STRIPE_STACK_UNWIND and then continuing to
    clean up "our" parts of the just-freed structure.  Oops.
    
    Change-Id: Ifa961b89cd21a2893de39a9eea243d184f9eac46
    BUG: 1228510
    Signed-off-by: Jeff Darcy <jdarcy>
    Reviewed-on: http://review.gluster.org/11037
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    (cherry picked from commit 62992ac27d729ecc7da500ce42dc46592c13d003)
    Reviewed-on: http://review.gluster.org/11145
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 Anand Avati 2015-06-10 12:39:51 UTC

REVIEW: http://review.gluster.org/11096 (build: fix compiling on older distributions) posted (#5) for review on release-3.7 by Atin Mukherjee (amukherj)

Comment 7 Niels de Vos 2015-06-20 09:50:03 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user