Bug 1228869
| Summary: | Review Request: gdouros-asea-fonts - an etude on the dominant typeface of Greek typography | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Ploumistos <alex.ploumistos> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fonts-bugs, gwync, kevin, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-23 20:07:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alexander Ploumistos
2015-06-06 00:59:11 UTC
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9963003 New spec file and source rpm. Spec URL: https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-asea-fonts/gdouros-asea-fonts.spec SRPM URL: https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-asea-fonts/gdouros-asea-fonts-5.01-1.fc23.src.rpm - name OK - license OK (see #1228865 for licensing discussion) - latest version - requires and provides seem OK Rpmlint: gdouros-aroania-fonts.noarch: W: spelling-error %description -l en_US monoline -> mono line, mono-line, monolingual gdouros-aroania-fonts.src: W: spelling-error %description -l en_US monoline -> mono line, mono-line, monolingual gdouros-aroania-fonts.src: W: invalid-url Source1: http://users.teilar.gr/~g1951d/Textfonts.pdf HTTP Error 404: Not Found gdouros-aroania-fonts.src: W: invalid-url Source0: http://users.teilar.gr/~g1951d/TextFonts.zip HTTP Error 404: Not Found OK. Package is APPROVED. Oops, wrong window. OK, this package is identical to the other two, except for the font name. Package is APPROVED. New Package SCM Request ======================= Package Name: gdouros-sea-fonts Short Description: an étude on the dominant typeface of Greek typography Upstream URL: http://users.teilar.gr/~g1951d/ Branches: f21 f22 f23 master Owners: alexpl InitialCC: fonts-sig Our git processing script is erroring on this package. (Likely due to the "é" in the description) I'm not sure this is allowed by the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description says: "Please put personal preferences aside and use American English spelling in the summary and description." I'm clearing the flag here so I can process the rest of the queue... (In reply to Kevin Fenzi from comment #7) > Our git processing script is erroring on this package. > > (Likely due to the "é" in the description) > > I'm not sure this is allowed by the guidelines: > > https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description > > says: > > "Please put personal preferences aside and use American English spelling in > the summary and description." > > I'm clearing the flag here so I can process the rest of the queue... I may be splitting hairs, but what is more preferable here, "an etude" without the accent or "a study"? Oh and will I need to upload new files with the description amended? > "an etude" without the accent or "a study"? "an etude" is standard English spelling afaik. > Oh and will I need to upload new files with the description amended? I don't think so. An amended fedora-cvs request should be enough. I'll also update the bug title right now so they match. New Package SCM Request ======================= Package Name: gdouros-sea-fonts Short Description: an etude on the dominant typeface of Greek typography Upstream URL: http://users.teilar.gr/~g1951d/ Branches: f21 f22 f23 master Owners: alexpl InitialCC: fonts-sig Oh crap, there was an "a" missing from the name in my request! New Package SCM Request ======================= Package Name: gdouros-asea-fonts Short Description: an etude on the dominant typeface of Greek typography Upstream URL: http://users.teilar.gr/~g1951d/ Branches: f21 f22 f23 master Owners: alexpl InitialCC: fonts-sig Git done (by process-git-requests). The repo was empty, so I had to set up the branches myself. Could you please take a look and see if everything is all right? Looks ok. |