Bug 1228869 - Review Request: gdouros-asea-fonts - an etude on the dominant typeface of Greek typography
Summary: Review Request: gdouros-asea-fonts - an etude on the dominant typeface of Gre...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-06 00:59 UTC by Alexander Ploumistos
Modified: 2015-07-23 20:07 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-07-23 20:07:00 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1228865 0 medium CLOSED Review Request: gdouros-anaktoria-fonts - A font based on "Grecs du roi" and the "First Folio Edition of Shakespeare" 2021-02-22 00:41:40 UTC

Internal Links: 1228865

Description Alexander Ploumistos 2015-06-06 00:59:11 UTC
Spec URL: https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-asea-fonts/gdouros-asea-fonts.spec

SRPM URL: https://alexpl.fedorapeople.org/packages/fonts/gdouros/gdouros-asea-fonts/gdouros-asea-fonts-5.01-1.fc22.src.rpm

Description: Asea is an étude on the dominant typeface of Greek typography. Upright Greek letters were designed in 1805 by Firmin Didot (1764-1836) and cut by Walfard and Vibert. The typeface, together with a complete printing house, was donated in 1821 to the new Greek state by Didot's son, Ambroise Firmin Didot (1790-1876).

The font covers the Windows Glyph List, IPA Extensions, Greek Extended, Ancient Greek Numbers, Byzantine and Ancient Greek Musical Notation, various typographic extras and several Open Type features (Case-Sensitive Forms, Small Capitals, Subscript, Superscript, Numerators, Denominators, Fractions, Old Style Figures, Historical Forms, Stylistic Alternates, Ligatures).

It was created by George Douros. 

Fedora Account System Username: alexpl

Comment 1 Alexander Ploumistos 2015-06-06 00:59:43 UTC
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9963003

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-07-17 18:43:24 UTC
- name OK
- license OK (see #1228865 for licensing discussion)
- latest version
- requires and provides seem OK

Rpmlint:
gdouros-aroania-fonts.noarch: W: spelling-error %description -l en_US monoline -> mono line, mono-line, monolingual
gdouros-aroania-fonts.src: W: spelling-error %description -l en_US monoline -> mono line, mono-line, monolingual
gdouros-aroania-fonts.src: W: invalid-url Source1: http://users.teilar.gr/~g1951d/Textfonts.pdf HTTP Error 404: Not Found
gdouros-aroania-fonts.src: W: invalid-url Source0: http://users.teilar.gr/~g1951d/TextFonts.zip HTTP Error 404: Not Found

OK.

Package is APPROVED.

Comment 4 Zbigniew Jędrzejewski-Szmek 2015-07-17 18:44:25 UTC
Oops, wrong window.

Comment 5 Zbigniew Jędrzejewski-Szmek 2015-07-17 18:45:56 UTC
OK, this package is identical to the other two, except for the font name. Package is APPROVED.

Comment 6 Alexander Ploumistos 2015-07-17 18:51:08 UTC
New Package SCM Request
=======================
Package Name: gdouros-sea-fonts
Short Description: an étude on the dominant typeface of Greek typography
Upstream URL: http://users.teilar.gr/~g1951d/
Branches: f21 f22 f23 master
Owners: alexpl
InitialCC: fonts-sig

Comment 7 Kevin Fenzi 2015-07-20 17:15:07 UTC
Our git processing script is erroring on this package. 

(Likely due to the "é" in the description)

I'm not sure this is allowed by the guidelines: 

https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

says: 

"Please put personal preferences aside and use American English spelling in the summary and description."

I'm clearing the flag here so I can process the rest of the queue...

Comment 8 Alexander Ploumistos 2015-07-20 22:47:02 UTC
(In reply to Kevin Fenzi from comment #7)
> Our git processing script is erroring on this package. 
> 
> (Likely due to the "é" in the description)
> 
> I'm not sure this is allowed by the guidelines: 
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description
> 
> says: 
> 
> "Please put personal preferences aside and use American English spelling in
> the summary and description."
> 
> I'm clearing the flag here so I can process the rest of the queue...

I may be splitting hairs, but what is more preferable here, "an etude" without the accent or "a study"?

Comment 9 Alexander Ploumistos 2015-07-20 22:48:01 UTC
Oh and will I need to upload new files with the description amended?

Comment 10 Zbigniew Jędrzejewski-Szmek 2015-07-20 23:13:32 UTC
> "an etude" without the accent or "a study"?
"an etude" is standard English spelling afaik.

> Oh and will I need to upload new files with the description amended?
I don't think so. An amended fedora-cvs request should be enough. I'll also update the bug title right now so they match.

Comment 11 Zbigniew Jędrzejewski-Szmek 2015-07-20 23:19:28 UTC
New Package SCM Request
=======================
Package Name: gdouros-sea-fonts
Short Description: an etude on the dominant typeface of Greek typography
Upstream URL: http://users.teilar.gr/~g1951d/
Branches: f21 f22 f23 master
Owners: alexpl
InitialCC: fonts-sig

Comment 12 Alexander Ploumistos 2015-07-20 23:21:00 UTC
Oh crap, there was an "a" missing from the name in my request!


New Package SCM Request
=======================
Package Name: gdouros-asea-fonts
Short Description: an etude on the dominant typeface of Greek typography
Upstream URL: http://users.teilar.gr/~g1951d/
Branches: f21 f22 f23 master
Owners: alexpl
InitialCC: fonts-sig

Comment 13 Gwyn Ciesla 2015-07-21 11:05:43 UTC
Git done (by process-git-requests).

Comment 14 Alexander Ploumistos 2015-07-21 14:10:39 UTC
The repo was empty, so I had to set up the branches myself. Could you please take a look and see if everything is all right?

Comment 15 Gwyn Ciesla 2015-07-23 15:44:02 UTC
Looks ok.


Note You need to log in before you can comment on or make changes to this bug.